Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

fix(convert): When converting devfile v1 to v2, registryUrl attribute is forgotten #1115

Merged
merged 1 commit into from
May 26, 2021
Merged

fix(convert): When converting devfile v1 to v2, registryUrl attribute is forgotten #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ions/eclipse-che-theia-remote-impl-che-server/src/node/che-server-devfile-service-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,10 @@ export class CheServerDevfileServiceImpl implements DevfileService {
if (componentV1.reference) {
devfileV2Component.plugin.url = componentV1.reference;
}
if (componentV1.registryUrl) {
devfileV2Component.plugin.registryUrl = componentV1.registryUrl;
}

if (componentV1.cpuLimit) {
devfileV2Component.plugin.cpuLimit = componentV1.cpuLimit;
}
Expand Down
1 change: 1 addition & 0 deletions extensions/eclipse-che-theia-remote-impl-che-server/tests/_data/devfile-go-v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ projects:
components:
- type: chePlugin
id: golang/go/latest
registryUrl: https://my-registry.fake
alias: go-plugin
memoryLimit: 512Mi
env:
Expand Down