This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
chore: should be able to uninstall plugins if che-theia-plugins.yaml is inlined in the devfile #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com.com
What does this PR do?
.che/che-theia-plugins.yaml
file is inlined in the devfile, all the plugins will be marked as installed. Does the same when the devfile contains.vscode/extensions.json
.che-theia-plugin.yaml
instead ofmeta.yaml
.Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#21423
How to test this PR?
To test the behavior with inlined
che-theia-plugins.yaml
create workspace with a factoryche-url#https://github.com/vitaliy-guliy/web-nodejs-sample/tree/inlined-che-theia-plugins-yaml?che-editor=https://gist.githubusercontent.com/vitaliy-guliy/bc6ff64a716a30bfc7492cec9314f3cf/raw/abcfeff8ccc9a1992fa9a6d4fe7a7a558dc7b7df/editor.meta.yaml
To test the behavior with inlined
extensions.json
useche-url#https://github.com/vitaliy-guliy/web-nodejs-sample/tree/che-qe-extensions-test?che-editor=https://gist.githubusercontent.com/vitaliy-guliy/bc6ff64a716a30bfc7492cec9314f3cf/raw/abcfeff8ccc9a1992fa9a6d4fe7a7a558dc7b7df/editor.meta.yaml
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable