Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

chore: should be able to uninstall plugins if che-theia-plugins.yaml is inlined in the devfile #1361

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Jul 19, 2022

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com.com

What does this PR do?

  • If .che/che-theia-plugins.yaml file is inlined in the devfile, all the plugins will be marked as installed. Does the same when the devfile contains .vscode/extensions.json.
  • For devworkspaces, switches to using che-theia-plugin.yaml instead of meta.yaml.

Screenshot/screencast of this PR

Screenshot from 2022-07-19 17-54-48

What issues does this PR fix or reference?

eclipse-che/che#21423

How to test this PR?

To test the behavior with inlined che-theia-plugins.yaml create workspace with a factory
che-url#https://github.com/vitaliy-guliy/web-nodejs-sample/tree/inlined-che-theia-plugins-yaml?che-editor=https://gist.githubusercontent.com/vitaliy-guliy/bc6ff64a716a30bfc7492cec9314f3cf/raw/abcfeff8ccc9a1992fa9a6d4fe7a7a558dc7b7df/editor.meta.yaml

To test the behavior with inlined extensions.json use
che-url#https://github.com/vitaliy-guliy/web-nodejs-sample/tree/che-qe-extensions-test?che-editor=https://gist.githubusercontent.com/vitaliy-guliy/bc6ff64a716a30bfc7492cec9314f3cf/raw/abcfeff8ccc9a1992fa9a6d4fe7a7a558dc7b7df/editor.meta.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

…is inlined in the devfile

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com.com>
@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review July 19, 2022 15:22
@vitaliy-guliy vitaliy-guliy requested review from vinokurig and svor July 19, 2022 15:23
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1361 (bcca2f1) into main (c299f59) will increase coverage by 3.90%.
The diff coverage is 39.61%.

@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   32.78%   36.69%   +3.90%     
==========================================
  Files         290      330      +40     
  Lines        9885    11478    +1593     
  Branches     1457     1506      +49     
==========================================
+ Hits         3241     4212     +971     
- Misses       6641     7261     +620     
- Partials        3        5       +2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 296 more

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on dogfooding instance, all plugins were installed and it's possible to install/unisntall plugins during the work
screenshot-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2022 07 21-14_00_34

screenshot-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2022 07 21-13_32_00

@svor
Copy link
Contributor

svor commented Jul 27, 2022

@azatsarynnyy @benoitf would you like to review this PR or I can merge it?

@benoitf
Copy link
Contributor

benoitf commented Jul 27, 2022

@svor you can merge

@azatsarynnyy
Copy link
Member

LGTM
please merge

@svor
Copy link
Contributor

svor commented Jul 27, 2022

Thanks!

@svor svor merged commit 16359d8 into main Jul 27, 2022
@svor svor deleted the vgulyy-che-21423 branch July 27, 2022 15:25
@che-bot che-bot added this to the 7.52 milestone Jul 27, 2022
@nickboldt
Copy link
Contributor

Building from main in https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/DS_CI/job/theia-sources_3.x/15/ (previous build died on s390x)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants