Allow to use VS Code builtin extensions in che-theia #572

tolusha · 2019-12-03T08:16:53Z

What does this PR do?

Allows to use VS Code builtin extensions in che-theia

What issues does this PR fix or reference?

eclipse-che/che#14759

generator/src/conf/builtin-extensions

generator/tests/builtin-extensions/builtin-extensions

benoitf · 2019-12-03T08:27:21Z

hello, why are we not using vsix for VS Code built-in extensions ?
--> eclipse-theia/vscode-builtin-extensions#13

Also using a different package name is not nice for dependencies against these deps.
this hack shouldn't exist: https://github.com/eclipse-theia/theia/pull/6207/files

che-bot · 2019-12-03T08:42:01Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:572
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:572

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

generator/tests/builtin-extensions/builtin-extensions.spec.ts

AndrienkoAleksandr · 2019-12-03T15:50:58Z

@tolusha theia/typescript.spec.ts fails, fix it, please. I guess it is, because you changed list build-in plugins.

tolusha · 2019-12-04T08:13:55Z

@benoitf
vsix files aren't published yet.

tolusha · 2019-12-04T08:55:05Z

@benoitf

Also using a different package name is not nice for dependencies against these deps.
this hack shouldn't exist: https://github.com/eclipse-theia/theia/pull/6207/files

Not sure if I understand you. Could you elaborate more?

che-bot · 2019-12-04T09:20:49Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:572
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:572

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

tolusha · 2019-12-09T12:47:30Z

@benoitf
Could I have some response pls)

tsmaeder · 2019-12-11T15:26:20Z

hello, why are we not using vsix for VS Code built-in extensions ?

Because some of the built-ins would translate to a separate Che plugin. For example, a theia image would not necessarily include a typescript compiler. Also, the referenced PR is quite new.

benoitf · 2019-12-11T15:50:45Z

Because some of the built-ins would translate to a separate Che plugin. For example, a theia image would not necessarily include a typescript compiler

I'm not sure to understand. To me npmjs or vsix only change the distribution channel.

tsmaeder · 2019-12-11T16:28:54Z

Because some of the built-ins would translate to a separate Che plugin. For example, a theia image would not necessarily include a typescript compiler

I'm not sure to understand. To me npmjs or vsix only change the distribution channel.

As I understand it, he generates a single vsix for all the extensions, which means we cannot omit any. With the npm published stuff, you can pick which ones you want.

benoitf · 2019-12-11T16:44:05Z

ok got it. After discussion another PR was created eclipse-theia/vscode-builtin-extensions#15 (to have one VSIX per extension)

che-bot · 2019-12-13T09:23:21Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:572
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:572

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-12-13T11:27:28Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:572
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:572

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

benoitf · 2019-12-17T13:11:20Z

@tolusha could you publish vsix files elsewhere as files are no longer there ?

che-bot · 2019-12-18T08:03:39Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:572
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:572

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

che-bot · 2019-12-21T09:49:18Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:572
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:572

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

tolusha · 2019-12-21T12:20:21Z

root ERROR Failed to resolve plugins from 'local-dir:///default-theia-plugins' Error: invalid comment length. expected: 2. found: 0
    at /home/theia/node_modules/yauzl/index.js:133:25
    at /home/theia/node_modules/yauzl/index.js:631:5
    at Immediate.<anonymous> (/home/theia/node_modules/fd-slicer/index.js:202:5)
    at runCallback (timers.js:705:18)
    at tryOnImmediate (timers.js:676:5)
    at processImmediate (timers.js:658:5)

dmytro-ndp · 2019-12-21T12:29:52Z

@tolusha: you can use test workspace devfile to run workspace with your changes locally.

tolusha · 2019-12-21T12:30:45Z

Cool!

tolusha · 2019-12-23T07:40:56Z

@tsmaeder @svor
Unfortunately this issue requires additional investigation

tsmaeder · 2020-01-13T09:42:25Z

'yauzl' being an unzip library, I suspect a broken zip/vsix. Unfortunately, the error message does not say which one.

tsmaeder · 2020-01-13T09:42:54Z

crw-ci-test

azatsarynnyy · 2020-01-22T10:23:04Z

Hello
Recently, a very similar mechanism was introduced in Theia upstream. For the details, see:

I think we can stop work on this PR and adapt Che Theia build instead to rely on the upstream:
download:plugins script provided by @theia/cli.

tsmaeder · 2020-01-22T15:24:42Z

Yes, it just comes down to updating the packages.json of our assembly as in the example @azatsarynnyy linked. I propose we close this PR in favor of a new one.

RomanNikitenko · 2020-02-19T14:12:27Z

Should we close the PR?
If I understand correctly, #618 brings VS Code builtin extensions in che-theia.

@azatsarynnyy @vzhukovskii

vzhukovs · 2020-02-19T14:13:42Z

cc @tolusha

azatsarynnyy · 2020-02-19T14:22:16Z

Should we close the PR?
If I understand correctly, #618 brings VS Code builtin extensions in che-theia.

@azatsarynnyy @vzhukovskii

Yes, it can be closed as we're relying on Theia's mechanism now.

vzhukovs · 2020-02-26T08:49:23Z

Closed due to irrelevance

Signed-off-by: Eric Williams <ericwill@redhat.com>

tolusha added the kind/task label Dec 3, 2019

tolusha requested review from benoitf, sunix, evidolob, AndrienkoAleksandr and mmorhun December 3, 2019 08:16

tolusha requested review from l0rd, rhopp and vparfonov as code owners December 3, 2019 08:16

tolusha self-assigned this Dec 3, 2019

benoitf reviewed Dec 3, 2019

View reviewed changes

generator/src/conf/builtin-extensions Outdated Show resolved Hide resolved

benoitf reviewed Dec 3, 2019

View reviewed changes

generator/tests/builtin-extensions/builtin-extensions Outdated Show resolved Hide resolved

benoitf reviewed Dec 3, 2019

View reviewed changes

generator/tests/builtin-extensions/builtin-extensions Outdated Show resolved Hide resolved

AndrienkoAleksandr reviewed Dec 3, 2019

View reviewed changes

generator/tests/builtin-extensions/builtin-extensions.spec.ts Show resolved Hide resolved

tolusha force-pushed the ab/builtinext branch from 10be393 to e7f3aa9 Compare December 18, 2019 07:45

tolusha added 12 commits December 21, 2019 09:51

Introduce theia:builtin-extensions

63411e2

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Introduce theia:builtin-extensions

e42e81c

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Update extensions list

a545954

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Update dockerfile

0098eb5

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

273868a

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

0e8c5da

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

7c97eac

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

34b29f1

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Use vsix packages

e665549

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Get rid of wget

515ce9d

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

80eb51f

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Update list of extensions

2afbc20

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha force-pushed the ab/builtinext branch from bd50f88 to 2afbc20 Compare December 21, 2019 07:52

tolusha mentioned this pull request Jan 22, 2020

Adapt Che Theia to use VSCode builtins instead of deprecated Theia extensions eclipse-che/che#15770

Closed

vzhukovs closed this Feb 26, 2020

vzhukovs deleted the ab/builtinext branch February 26, 2020 08:50

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

Update java11 sidecars with new alpine 3.12 based image (#572)

b0d55cd

Signed-off-by: Eric Williams <ericwill@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to use VS Code builtin extensions in che-theia #572

Allow to use VS Code builtin extensions in che-theia #572

tolusha commented Dec 3, 2019 •

edited

Loading

benoitf commented Dec 3, 2019

che-bot commented Dec 3, 2019

AndrienkoAleksandr commented Dec 3, 2019

tolusha commented Dec 4, 2019

tolusha commented Dec 4, 2019

che-bot commented Dec 4, 2019

tolusha commented Dec 9, 2019

tsmaeder commented Dec 11, 2019

benoitf commented Dec 11, 2019

tsmaeder commented Dec 11, 2019 •

edited

Loading

benoitf commented Dec 11, 2019

che-bot commented Dec 13, 2019

che-bot commented Dec 13, 2019

benoitf commented Dec 17, 2019

che-bot commented Dec 18, 2019

che-bot commented Dec 21, 2019

tolusha commented Dec 21, 2019

dmytro-ndp commented Dec 21, 2019

tolusha commented Dec 21, 2019

tolusha commented Dec 23, 2019

tsmaeder commented Jan 13, 2020

tsmaeder commented Jan 13, 2020

azatsarynnyy commented Jan 22, 2020

tsmaeder commented Jan 22, 2020

RomanNikitenko commented Feb 19, 2020

vzhukovs commented Feb 19, 2020

azatsarynnyy commented Feb 19, 2020

vzhukovs commented Feb 26, 2020

Allow to use VS Code builtin extensions in che-theia #572

Allow to use VS Code builtin extensions in che-theia #572

Conversation

tolusha commented Dec 3, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

benoitf commented Dec 3, 2019

che-bot commented Dec 3, 2019

AndrienkoAleksandr commented Dec 3, 2019

tolusha commented Dec 4, 2019

tolusha commented Dec 4, 2019

che-bot commented Dec 4, 2019

tolusha commented Dec 9, 2019

tsmaeder commented Dec 11, 2019

benoitf commented Dec 11, 2019

tsmaeder commented Dec 11, 2019 • edited Loading

benoitf commented Dec 11, 2019

che-bot commented Dec 13, 2019

che-bot commented Dec 13, 2019

benoitf commented Dec 17, 2019

che-bot commented Dec 18, 2019

che-bot commented Dec 21, 2019

tolusha commented Dec 21, 2019

dmytro-ndp commented Dec 21, 2019

tolusha commented Dec 21, 2019

tolusha commented Dec 23, 2019

tsmaeder commented Jan 13, 2020

tsmaeder commented Jan 13, 2020

azatsarynnyy commented Jan 22, 2020

tsmaeder commented Jan 22, 2020

RomanNikitenko commented Feb 19, 2020

vzhukovs commented Feb 19, 2020

azatsarynnyy commented Feb 19, 2020

vzhukovs commented Feb 26, 2020

tolusha commented Dec 3, 2019 •

edited

Loading

tsmaeder commented Dec 11, 2019 •

edited

Loading