Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Che Theia to use VSCode builtins instead of deprecated Theia extensions #15770

Closed
azatsarynnyy opened this issue Jan 21, 2020 · 6 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@azatsarynnyy
Copy link
Member

Is your task related to a problem? Please describe.

In Theia upstream, several extensions are deprecated and going to be removed soon, see eclipse-theia/theia#6933
VS Code built-in extensions are used instead, see eclipse-theia/theia#6883

Describe the solution you'd like

We need to adapt Che Theia to exclude the deprecated extensions and include the corresponding VS Code builtins instead.

Describe alternatives you've considered

Additional context

@theia/cli provides download:plugins script to fetch the VS Code plugins.
For the details, see:

@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che labels Jan 21, 2020
@gattytto
Copy link

#14759 this seems to be a builtins sprint tho I think there's yet another one made by @tsmaeder

@tolusha
Copy link
Contributor

tolusha commented Jan 22, 2020

@azatsarynnyy
As @gattytto noticed, the work is almost done eclipse-che/che-theia#572

@azatsarynnyy
Copy link
Member Author

@tolusha do you think we should have yet another mechanism of installing VS Code built-in extensions apart from the one provided by Theia upstream?

I understand that there's work on Che Theia generator that is in progress. And it has been started before it was added to Theia. But what's the point of introducing and supporting our own mechanism while very similar one is already supported upstream? We could just rely on it after slightly adapting Che Theia build.
Maybe I just misunderstood something... 🙂

@benoitf WDYT?

@tsmaeder
Copy link
Contributor

Duplicate of #14759. Please discuss issues with the current PR over there.

@benoitf
Copy link
Contributor

benoitf commented Jan 22, 2020

@azatsarynnyy Anatolii's PR is a base to start but of course we should use now the upstream download-script to grab plug-ins (and how we specify the list of plug-ins in package.json file) (through the assembly template)

@benoitf
Copy link
Contributor

benoitf commented Jan 22, 2020

moving to #14759

@benoitf benoitf closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants