Remove Deprecated Extensions #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
3 times, most recently
from
f802a7d
to
25e40e0
Compare
1 task
1 task
|
We should also review theia docs and theia extension generator to make sure that we don't mention them anymore or replace with corresponding VS Code extension. For instance https://theia-ide.org/docs/composing_applications/ is missing a section how to include support of VS Code extensions. |
This was referenced Jan 22, 2020
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
from
d4ae70f
to
9714075
Compare
|
Placing it as "Ready for Review" so I can anticipate any breakage/merge conflicts :) |
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
from
9714075
to
ea870aa
Compare
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
2 times, most recently
from
80a866a
to
af0dae8
Compare
Closed
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
3 times, most recently
from
e86368a
to
123f9d7
Compare
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
from
123f9d7
to
1ed7262
Compare
This was referenced Feb 12, 2020
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
from
1ed7262
to
41f67b9
Compare
Thanks @vince-fugnitto . I added a couple more comments in this area. |
Removes the `@theia/java-debug` extension since it is contributed by a builtin extension, and will no longer be maintained by the project. The extension remains in the Git history for anyone who would like to reference it or maintain it. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Removes the `@theia/java` extension since it is contributed by a builtin extension, and will no longer be maintained by the project. The extension remains in the Git history for anyone who would like to reference it or maintain it. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Removes the `@theia/merge-conflicts` extension since it is contributed by a builtin extension, and will no longer be maintained by the project. The extension remains in the Git history for anyone who would like to reference it or maintain it. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Removes the `@theia/python` extension since it is contributed by a builtin extension, and will no longer be maintained by the project. The extension remains in the Git history for anyone who would like to reference it or maintain it. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Removes the `@theia/textmate-grammars` extension since it is contributed by a builtin extension, and will no longer be maintained by the project. The extension remains in the Git history for anyone who would like to reference it or maintain it. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Removes the `@theia/tslint` extension since it is contributed by a builtin extension, and will no longer be maintained by the project. The extension remains in the Git history for anyone who would like to reference it or maintain it. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Removes the `@theia/typescript` extension since it is contributed by a builtin extension, and will no longer be maintained by the project. The extension remains in the Git history for anyone who would like to reference it or maintain it. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
from
c95ca26
to
41262a6
Compare
@marcdumais-work I've addressed the comments if you'd like to take a look. |
|
@marcdumais-work feel free to merge if you are happy with the changes 😃 |
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
from
41262a6
to
f7dca0e
Compare
This commit updates the `changelog` following the removal of deprecated extensions from the repository. The commit includes the following: - A link for application developers to our wiki page for `migration` steps. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/ext-refactorings
branch
from
f7dca0e
to
670d14f
Compare
1 task
|
Looks good, thanks @vince-fugnitto . Merging. |
This was referenced Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request removes deprecated extensions from the repository since these extensions will no longer be maintained and are either replaced by
builtinor external VS Code extensions:@theia/debug-nodejs@theia/editorconfig@theia/java@theia/java-debug@theia/merge-conflicts@theia/python@theia/textmate-grammars@theia/tslint@theia/typescriptPrerequisite
How to test
Verify that CI successfully passes (build & tests)
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com