Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C/C++ grammar files from VSCode #6944

Closed
wants to merge 1 commit into from

Conversation

alexl0gan
Copy link
Contributor

@alexl0gan alexl0gan commented Jan 22, 2020

What it does

Update textmate-grammars package to use vscode grammar files as defined here:
https://github.com/jeff-hykin/cpp-textmate-grammar
https://github.com/microsoft/vscode/tree/master/extensions/cpp/syntaxes

How to test

Open a C/C++ file and enjoy a richer syntax colourisation.

Review checklist

Reminder for reviewers

Signed-off-by: Alex Logan Alex.Logan@arm.com

Signed-off-by: Alex Logan <Alex.Logan@arm.com>
@vince-fugnitto
Copy link
Member

@alexl0gan the extension @theia/texmate-grammars will be deprecated soon #6933 in favor of using the builtin extensions. Perhaps the grammars would be more appropriate if added to theia-cpp-extensions.

@vince-fugnitto
Copy link
Member

Also, you referenced that your changes are based on https://github.com/jeff-hykin/cpp-textmate-grammar, would it not be simpler just to use it as a plugin?

@alexl0gan
Copy link
Contributor Author

@vince-fugnitto I thought the grammar files were moved out of that repo?

I guess when the move is made to builtin extensions then theia will start using these files anyway

@vince-fugnitto
Copy link
Member

I guess when the move is made to builtin extensions then theia will start using these files anyway

We have already moved towards using the builtin extensions in the examples (#6883), and any other extension such as https://github.com/jeff-hykin/cpp-textmate-grammar can now simply be used as a plugin. In the end, there will be less need for maintenance and to copy files in our sources.

@vince-fugnitto
Copy link
Member

I believe this pull-request can be closed based on our discussions.

@akosyakov akosyakov added the textmate issues related to the textmate grammars label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
textmate issues related to the textmate grammars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants