Fix import of zip project in case the archive is hosted on the same cluster which uses self-signed certificate #672

mmorhun · 2020-03-18T11:41:32Z

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Fixes import of zip project when it is hosted in the same cluster as Che and the cluster uses self-signed certificate.

mmorhun · 2020-03-18T11:42:48Z

I would like reviewers to try it out.

che-bot · 2020-03-18T12:19:25Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2020-03-18T12:58:44Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2020-03-18T12:58:55Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2020-03-18T13:00:46Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2020-03-18T13:01:24Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

plugins/workspace-plugin/src/theia-commands.ts

mmorhun · 2020-03-19T08:56:07Z

Rebased

che-bot · 2020-03-19T09:00:37Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-03-19T09:05:55Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

davidfestal · 2020-03-19T09:27:22Z

And would it be possible to have a corresponding PR on the 7.9.x branch. That's quite important for the CRW 2.1 ?

mmorhun · 2020-03-19T10:00:45Z

@davidfestal yes, sure, I'll provide a backport.

mmorhun · 2020-03-19T10:27:22Z

From the CI build logs:

@eclipse-che/theia-remote: [compile] src/node/plugin-remote-init.ts(377,7): error TS2420: Class 'PluginDeployerHandlerImpl' incorrectly implements interface 'PluginDeployerHandler'.
@eclipse-che/theia-remote: [compile]   Property 'undeployPlugin' is missing in type 'PluginDeployerHandlerImpl' but required in type 'PluginDeployerHandler'.

And it is not related to current PR...

azatsarynnyy · 2020-03-19T10:47:00Z

From the CI build logs:

@eclipse-che/theia-remote: [compile] src/node/plugin-remote-init.ts(377,7): error TS2420: Class 'PluginDeployerHandlerImpl' incorrectly implements interface 'PluginDeployerHandler'.
@eclipse-che/theia-remote: [compile]   Property 'undeployPlugin' is missing in type 'PluginDeployerHandlerImpl' but required in type 'PluginDeployerHandler'.

And it is not related to current PR...

@mmorhun the fix is on the way #676

davidfestal · 2020-03-19T13:52:09Z

@mmorhun do you also plan to remove the -s flag here (as done on the backported PR ?)

mmorhun · 2020-03-19T13:52:49Z

@davidfestal yes, but wait when the CI build is fixed to not to build twice

nickboldt · 2020-03-19T16:01:29Z

Instead of removing -s we can use -sS to be quiet but still throw errors if errors happen.

-S/--show-error
When used with -s it makes curl show an error message if it fails.

che-bot · 2020-03-19T16:05:51Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

azatsarynnyy · 2020-03-19T16:55:22Z

@mmorhun #676 is merged. It adapts Che Theia to the latest upstream Theia changes.
So, the build is fixed but the Happy Path tests are failing because of eclipse-che/che#16403
QE Team is working on it.

…luster which uses self-signed certificate Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

``` -S/--show-error When used with -s it makes curl show an error message if it fails. ```

che-bot · 2020-03-23T08:31:59Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:672
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:672

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Fixes eclipse-che/che#18183 Signed-off-by: Eric Williams <ericwill@redhat.com>

mmorhun requested review from dmytro-ndp, vitaliy-guliy, ericwill and vinokurig March 18, 2020 11:41

mmorhun requested a review from benoitf as a code owner March 18, 2020 11:41

tolusha mentioned this pull request Mar 18, 2020

Che Deploy Sprint #181 eclipse-che/che#16237

Closed

45 tasks

mmorhun force-pushed the fix-import-zip-projects-tls branch from 3edd280 to 2f9b2f2 Compare March 18, 2020 12:21

mmorhun requested a review from azatsarynnyy as a code owner March 18, 2020 12:21

dmytro-ndp mentioned this pull request Mar 18, 2020

Che 7.9.2 Release eclipse-che/che#16229

Closed

27 tasks

mmorhun force-pushed the fix-import-zip-projects-tls branch from 2f9b2f2 to dd5210d Compare March 18, 2020 12:23

mmorhun requested review from RomanNikitenko and vzhukovs as code owners March 18, 2020 12:23

mmorhun force-pushed the fix-import-zip-projects-tls branch 2 times, most recently from b8832de to 83987d3 Compare March 18, 2020 12:28

mmorhun removed request for vzhukovs and RomanNikitenko March 18, 2020 12:35

davidfestal suggested changes Mar 18, 2020

View reviewed changes

plugins/workspace-plugin/src/theia-commands.ts Show resolved Hide resolved

mmorhun force-pushed the fix-import-zip-projects-tls branch from 50e4e4a to 7c2b7de Compare March 19, 2020 08:54

mmorhun mentioned this pull request Mar 19, 2020

Fix import of zip project which hosted with cluster self-signed certificate #678

Merged

davidfestal approved these changes Mar 19, 2020

View reviewed changes

mmorhun and others added 4 commits March 23, 2020 09:54

Fix import of zip project in case the archive is hosted on the same c…

17fa0c0

…luster which uses self-signed certificate Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Use curl instead of wget

c79ce3c

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Use curl instead of wget

6315e5a

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Update theia-commands.ts

dd77487

``` -S/--show-error When used with -s it makes curl show an error message if it fails. ```

mmorhun force-pushed the fix-import-zip-projects-tls branch from dbdfa9c to dd77487 Compare March 23, 2020 07:57

mmorhun merged commit 919bd91 into master Mar 23, 2020

mmorhun deleted the fix-import-zip-projects-tls branch March 23, 2020 09:45

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

Keep only the latest version of every plugin (#672)

0fed02e

Fixes eclipse-che/che#18183 Signed-off-by: Eric Williams <ericwill@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix import of zip project in case the archive is hosted on the same cluster which uses self-signed certificate #672

Fix import of zip project in case the archive is hosted on the same cluster which uses self-signed certificate #672

mmorhun commented Mar 18, 2020 •

edited

Loading

mmorhun commented Mar 18, 2020 •

edited

Loading

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

mmorhun commented Mar 19, 2020

che-bot commented Mar 19, 2020

che-bot commented Mar 19, 2020

davidfestal commented Mar 19, 2020

mmorhun commented Mar 19, 2020

mmorhun commented Mar 19, 2020

azatsarynnyy commented Mar 19, 2020

davidfestal commented Mar 19, 2020

mmorhun commented Mar 19, 2020

nickboldt commented Mar 19, 2020

che-bot commented Mar 19, 2020

azatsarynnyy commented Mar 19, 2020

che-bot commented Mar 23, 2020

Fix import of zip project in case the archive is hosted on the same cluster which uses self-signed certificate #672

Fix import of zip project in case the archive is hosted on the same cluster which uses self-signed certificate #672

Conversation

mmorhun commented Mar 18, 2020 • edited Loading

What does this PR do?

mmorhun commented Mar 18, 2020 • edited Loading

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

che-bot commented Mar 18, 2020

mmorhun commented Mar 19, 2020

che-bot commented Mar 19, 2020

che-bot commented Mar 19, 2020

davidfestal commented Mar 19, 2020

mmorhun commented Mar 19, 2020

mmorhun commented Mar 19, 2020

azatsarynnyy commented Mar 19, 2020

davidfestal commented Mar 19, 2020

mmorhun commented Mar 19, 2020

nickboldt commented Mar 19, 2020

che-bot commented Mar 19, 2020

azatsarynnyy commented Mar 19, 2020

che-bot commented Mar 23, 2020

mmorhun commented Mar 18, 2020 •

edited

Loading

mmorhun commented Mar 18, 2020 •

edited

Loading