Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

fix(deployment): Fix the plugin-remote init which is missing now a method #676

Merged
merged 3 commits into from
Mar 19, 2020
Merged

fix(deployment): Fix the plugin-remote init which is missing now a method #676

merged 3 commits into from
Mar 19, 2020

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Mar 19, 2020

What does this PR do?

Add unimplemented method

What issues does this PR fix or reference?

Fix eclipse-che/che#16393

Change-Id: I22e1a15dae39153f1d3b5cf55b6a6f6d31711c17
Signed-off-by: Florent Benoit fbenoit@redhat.com

@benoitf
fix(deployment): Fix the plugin-remote init which is missing now a me…
b332fb0 
…thod

Change-Id: I22e1a15dae39153f1d3b5cf55b6a6f6d31711c17
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@azatsarynnyy
Copy link
Member

crw-ci-test

@azatsarynnyy azatsarynnyy mentioned this pull request Mar 19, 2020
Merged
@azatsarynnyy
fix build
504c825 
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Copy link
Member

It looks like the build error

[compile] ../../../node_modules/htmlparser2/lib/CollectingHandler.d.ts(5,29): error TS1110: Type expected.

on github-auth-plugin is caused by "typescript": "2.9.2" dependency.
I've added the fix 504c825 to the PR

@benoitf
Copy link
Contributor Author

benoitf commented Mar 19, 2020

crw-ci-test

@azatsarynnyy
fix build
6196b1f 
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Copy link
Member

added the same fix for telemetry-plugin 6196b1f

vitaliy-guliy
vitaliy-guliy approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to merge this PR to stabilize the build

@azatsarynnyy
Copy link
Member

[ci-build]

@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:676
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:676

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Mar 19, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Mar 19, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Mar 19, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Mar 19, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Mar 19, 2020
@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:676
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:676

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@benoitf
Copy link
Contributor Author

benoitf commented Mar 19, 2020

@azatsarynnyy should we merge like this or wait happy path to be successful ?

@azatsarynnyy
Copy link
Member

@benoitf I've just asked @dmytro-ndp to look at it as it has failed several times with
Known flakiness has occurred https://github.com/eclipse/che/issues/14944
I'm not sure whether we can do something with it. We already rerun the tests several times.

@azatsarynnyy
Copy link
Member

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:676
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:676

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member

I'm merging the PR as Happy Path tests are failing ATM because of eclipse-che/che#16403
QE Team is working on it.

@azatsarynnyy azatsarynnyy merged commit 4c09edc into eclipse-che:master Mar 19, 2020
@benoitf benoitf deleted the CHE-16393 branch March 19, 2020 16:54
@dmytro-ndp dmytro-ndp mentioned this pull request Mar 20, 2020
Closed
26 tasks
@azatsarynnyy azatsarynnyy mentioned this pull request Mar 20, 2020
Merged
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@ericwill
Move sidecar definitions into the plugin registry (part I) (#676)
c939ba4 
* Move sidecar definitions into the plugin registry

Part 1 of the migration. I am doing it in parts because doing it all at once
will likely cause a build timeout upon pushing.

Part of eclipse-che/che#18217

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Handle java and java8 separately

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@vzhukovs vzhukovs vzhukovs approved these changes

@azatsarynnyy azatsarynnyy Awaiting requested review from azatsarynnyy

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko

@ericwill ericwill Awaiting requested review from ericwill

@vinokurig vinokurig Awaiting requested review from vinokurig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt changes in che-theia to respect changes in upstream theia
5 participants
@benoitf @azatsarynnyy @che-bot @vitaliy-guliy @vzhukovs