Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP and PHP + MySQL Che-7 stacks with samples #13434

Merged
merged 2 commits into from
May 30, 2019
Merged

Add PHP and PHP + MySQL Che-7 stacks with samples #13434

merged 2 commits into from
May 30, 2019

Conversation

svor
Copy link
Contributor

@svor svor commented May 28, 2019

What does this PR do?

Adds PHP and PHP + MySQL Che-7 stacks which include next plugins:

Adds samples:

What issues does this PR fix or reference?

#13307

svor added 2 commits May 24, 2019 14:47
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor
Copy link
Contributor Author

svor commented May 28, 2019

ci-test

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just wondering if we need the corresponding devfiles in Che Devfile Registry, maybe a separate issue to port them. @l0rd WDYT?

@che-bot
Copy link
Contributor

che-bot commented May 28, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13434
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@tolusha
Copy link
Contributor

tolusha commented May 29, 2019

ci-test

@l0rd
Copy link
Contributor

l0rd commented May 29, 2019

@sleshchenko @svor yes it would be better to start contributing to the devfile-registry directly. But that can be done on a separate PR as well.

@che-bot
Copy link
Contributor

che-bot commented May 29, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13434
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1819//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@svor svor merged commit 5165392 into master May 30, 2019
@svor svor deleted the sv/php branch May 30, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants