-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP and PHP + MySQL Che-7 stacks with samples #13434
Conversation
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
ci-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just wondering if we need the corresponding devfiles in Che Devfile Registry, maybe a separate issue to port them. @l0rd WDYT?
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
@sleshchenko @svor yes it would be better to start contributing to the devfile-registry directly. But that can be done on a separate PR as well. |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1819//Selenium_20tests_20report/) doesn't show any regression against this Pull Request. |
What does this PR do?
Adds PHP and PHP + MySQL Che-7 stacks which include next plugins:
Adds samples:
What issues does this PR fix or reference?
#13307