Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackService decommissioning #13459

Closed
skabashnyuk opened this issue May 31, 2019 · 9 comments
Closed

StackService decommissioning #13459

skabashnyuk opened this issue May 31, 2019 · 9 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

Description

After we setup devfile registry #13355 and adapted it to use in the dashboard #13354 it makes sense to think about StackService decommissioning

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/platform labels May 31, 2019
@l0rd l0rd mentioned this issue Jun 4, 2019
@sleshchenko
Copy link
Member

Note that in the scope of this issue it's needed to make sure that all stacks stacks.json are migrated to Devfile Registry which are specified in the following epic: #12620.
For example: PHP and PHP+Mysql were not migrated yet #13434

@skabashnyuk
Copy link
Contributor Author

marked as 7.1.0 since it's not critical for GA

@ibuziuk
Copy link
Member

ibuziuk commented Jul 29, 2019

for me it is not clear why "Stacks" Tab is exposed on UD. Stacks service could be decommissioned any time after GA, but I do not understand why we still have "Stacks" on UD if for workspace creation only devfiles from the registry are used @ashumilova @slemeur could you please clarify?

@ashumilova
Copy link
Contributor

That "Stacks" Tab now displays the list of devfiles from registry (all the same as on workspace creation page). And you can open "stack" details - see the raw devfile content.

@slemeur
Copy link
Contributor

slemeur commented Jul 30, 2019 via email

@ibuziuk
Copy link
Member

ibuziuk commented Jul 30, 2019

@ashumilova @slemeur thanks, but is it in rc 4 or in master only ?

@ibuziuk
Copy link
Member

ibuziuk commented Jul 30, 2019

I checked the history and looks like Adapt Stacks in UD to Che 7 is in master only. Anyway, great that this will be part of the GA! (currently Stacks tab was really misleading for me)

@ashumilova
Copy link
Contributor

yes, it was merged after RC 4

@mkuznyetsov
Copy link
Contributor

PR put on hold until 7.1.0:
#14078

@slemeur slemeur added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

6 participants