Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Updates to tag versions based on current stack images used #1509

Closed
wants to merge 1 commit into from
Closed

Conversation

kevchu3
Copy link

@kevchu3 kevchu3 commented Jul 25, 2019

What does this PR do?

This update to the stacks definition file will properly allow the Workspaces UI interface to display the correct tags and minor version numbers used.

What issues does this PR fix or reference?

For some stacks, the component minor version numbers are incorrect.

How have you tested this PR?

Yes, tested each stack image by spinning it up and checking versions.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@ibuziuk
Copy link
Member

ibuziuk commented Jul 29, 2019

@kevchu3 thanks for the PR, but in the short run we are going to switch from stacks to devfiles - https://github.com/eclipse/che-devfile-registry for Che 7 GA release, so I do not think we will have this PR merged

@ibuziuk
Copy link
Member

ibuziuk commented Jul 29, 2019

@skabashnyuk am I correct that stacks.json has been removed in the latest upstream rc4 release as part of Che 6 legacy code cleanup eclipse-che/che#13788? Basically, in rc4 "Stacks" tab of UD is based on devfiles, right ?

@skabashnyuk
Copy link
Collaborator

@skabashnyuk am I correct that stacks.json has been removed in the latest upstream rc4 release as part of Che 6 legacy code cleanup eclipse-che/che#13788?

They not. https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-workspace/src/test/resources/stacks.json planning to do that as part of eclipse-che/che#13459

@ibuziuk
Copy link
Member

ibuziuk commented Jul 29, 2019

@skabashnyuk thanks for the clarification. For some reason, I thought that stacks.json was part of ide folder that was removed in the latest release. Am I correct that currently neither stacks.json nor stacks service are used by UD in rc 4?

@skabashnyuk
Copy link
Collaborator

Not sure about rc4 it has to be received in git history.

@ibuziuk
Copy link
Member

ibuziuk commented Jul 30, 2019

Closing since stacks.json were removed as part of the #1481

@kevchu3 if you have any suggestion please contribute to https://github.com/eclipse/che-devfile-registry
Devfile info - https://redhat-developer.github.io/devfile/

@ibuziuk ibuziuk closed this Jul 30, 2019
@kevchu3
Copy link
Author

kevchu3 commented Jul 30, 2019

Closing since stacks.json were removed as part of the #1481

@kevchu3 if you have any suggestion please contribute to https://github.com/eclipse/che-devfile-registry
Devfile info - https://redhat-developer.github.io/devfile/

That makes sense, and thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants