Enable to set URLs for custom registries. #13455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
monaka
added
the
kind/enhancement
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this PR? |
sleshchenko
approved these changes
May 31, 2019
l0rd
approved these changes
May 31, 2019
|
ci-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masaki Muranaka monaka@monami-ya.com
What does this PR do?
Enables to set
CHE_WORKSPACE_DEVFILE__REGISTRY__URLandCHE_WORKSPACE_PLUGIN__REGISTRY__URLon deployments with Helm.What issues does this PR fix or reference?
refs #13430