Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the deployment failure with default values.yaml. #13598

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fix the deployment failure with default values.yaml. #13598

merged 1 commit into from
Jun 27, 2019

Conversation

monaka
Copy link
Member

@monaka monaka commented Jun 21, 2019

This will fix #13558.

Signed-off-by: Masaki Muranaka monaka@monami-ya.com

What does this PR do?

  • Checks if nil to places referencing che.*.
  • Quotes some URL values

What issues does this PR fix or reference?

Issue

PR

@monaka
Fix the deployment failure with default values.yaml.
2051ebb 
This will fix #13558.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@che-bot
Copy link
Contributor

che-bot commented Jun 21, 2019

Can one of the admins verify this patch?

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Jun 21, 2019

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Jun 21, 2019

Can one of the admins verify this patch?

@monaka
Copy link
Member Author

monaka commented Jun 21, 2019

I checked this by calling helm lint and helm install --dry-run --debug . with both commented (default) and uncommented vaule.yaml

@monaka monaka mentioned this pull request Jun 21, 2019
Closed
@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@sleshchenko
Copy link
Member

ci-build

@monaka
Copy link
Member Author

monaka commented Jun 21, 2019

It looks the test failed at unrelated place...

@skabashnyuk
Copy link
Contributor

ci-build

@ssh24
Copy link

ssh24 commented Jun 21, 2019

Nice! Thanks for creating the alternative PR @monaka

@monaka monaka requested a review from skabashnyuk June 25, 2019 04:49
@monaka
Copy link
Member Author

monaka commented Jun 26, 2019

Could anybody approve this?

@benoitf
Copy link
Contributor

benoitf commented Jun 26, 2019

@skabashnyuk @l0rd @sleshchenko could you please review ?

@sleshchenko
Copy link
Member

@monaka Thanks for this contribution 👍
Feel free to merge if you test it.

@monaka monaka merged commit fb41e43 into eclipse-che:master Jun 27, 2019
@monaka monaka deleted the pr-fix-13448 branch June 27, 2019 08:21
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 27, 2019
@johnmcollier johnmcollier mentioned this pull request Jun 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Unable to install via helm with default values.yaml.
7 participants
@monaka @che-bot @musienko-maxim @sleshchenko @skabashnyuk @ssh24 @benoitf