Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch and provide startup logs (workspace + broker pods) #16126

Merged
merged 59 commits into from
Feb 27, 2020
Merged

Watch and provide startup logs (workspace + broker pods) #16126

merged 59 commits into from
Feb 27, 2020

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Feb 25, 2020

This effectively replaces and enhances the original PR #15988

What does this PR do?

Watch the logs of all containers in workspace pod and plugin broker pod during workspace startup. Feature is disabled by default. It can be enabled on workspace startup REST API with new query parameter debug-workspace-start. If it is set to true, logs will be watched and printed during the startup.

so API call looks like this:
<che-host>/api/workspace/{id}/runtime?debug-workspace-start=true

What issues does this PR fix or reference?

#15983
#16117

Docs PR

will be part of followup UI-based tasks #16050 #16063 #16119

Additional context

epic: #15047

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…sted in

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…ool... can this thing get any better?

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…w responsible for handling just single log messages

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
# Conflicts:
#	infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/KubernetesInternalRuntime.java
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…ethod

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

…ew more review fixes

Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@amisevsk
Copy link
Contributor

* More informational than a question: I've noticed that the infrastructure for che.openshift.io sometimes randomly closes watches shortly after they're opened, so we should keep this in mind if we need to debug this feature on che.openshift.io.

Thanks, I didn't know about this. Do we have some metrics? Maybe good idea to measure it here. Do we know why it's happening?

I have no idea why it happens, but had to work around something like this in the kubernetes image puller. It may even be a k8s client-go issue, so we might not see it on the Che side.

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo sparkoo requested a review from ibuziuk as a code owner February 26, 2020 17:59
Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@dmytro-ndp
Copy link
Contributor

@sparkoo: java selenium tests failed because of known test flakiness in master.

@sparkoo sparkoo merged commit bffe11e into eclipse-che:master Feb 27, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 27, 2020
@che-bot che-bot added this to the 7.10.0 milestone Feb 27, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Feb 27, 2020
@sparkoo sparkoo deleted the brokerLogs branch March 2, 2020 05:54
@che-bot
Copy link
Contributor

che-bot commented Mar 10, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@che-bot
Copy link
Contributor

che-bot commented Mar 10, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants