Fix workspace creation and debug profiles for devsandbox periodic tests #20141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
ScrewTSW
requested review from
Katka92,
musienko-maxim,
nickboldt,
Ohrimenko1988 and
rhopp
as code owners
che-bot
added
target/branch
| // workaround for debug configuration not present | ||
| await this.debugView.clickOnDebugConfigurationItem('Add Configuration...'); | ||
| await this.debugView.clickOnDebugConfigurationDropDown(); | ||
| // === |
There was a problem hiding this comment.
In my eyes, this is extra. I would suggest to leave just empty row.
There was a problem hiding this comment.
This is the way the fix was implemented in your PR, instead of doing the refresh and it fixed our problems when I tried it from a custom-built dockerimage
Ohrimenko1988
approved these changes
Jul 16, 2021
Katka92
approved these changes
Jul 19, 2021
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#20140
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.