Creation of thing's policy is atomic with creation the of thing itself #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thjaeckle can you take a look when you can please. |
Signed-off-by: Stanchev Aleksandar <aleksandar.stanchev@bosch.io> Signed-off-by: Stanchev Aleksandar <aleksandar.stanchev@bosch.io>
alstanchev
force-pushed
the
feature/atomic-thing-create
branch
from
51a0043 to
77b1c03
Compare
|
@alstanchev I will take a look soon. |
thjaeckle
reviewed
Feb 22, 2023
...in/java/org/eclipse/ditto/internal/utils/persistentactors/AbstractPersistenceSupervisor.java
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
...ervice/src/main/java/org/eclipse/ditto/things/service/enforcement/RollbackCreatedPolicy.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
...ervice/src/main/java/org/eclipse/ditto/things/service/enforcement/RollbackCreatedPolicy.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
...ervice/src/main/java/org/eclipse/ditto/things/service/enforcement/RollbackCreatedPolicy.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
...ervice/src/main/java/org/eclipse/ditto/things/service/enforcement/RollbackCreatedPolicy.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
...ervice/src/main/java/org/eclipse/ditto/things/service/enforcement/RollbackCreatedPolicy.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
...s/service/src/main/java/org/eclipse/ditto/things/service/enforcement/ThingPolicyCreated.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
...s/service/src/main/java/org/eclipse/ditto/things/service/enforcement/ThingPolicyCreated.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
.../src/main/java/org/eclipse/ditto/things/service/persistence/actors/ThingSupervisorActor.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 22, 2023
.../src/main/java/org/eclipse/ditto/things/service/persistence/actors/ThingSupervisorActor.java
Outdated
Show resolved
Hide resolved
thjaeckle
requested changes
Feb 22, 2023
.../src/main/java/org/eclipse/ditto/things/service/persistence/actors/ThingSupervisorActor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/ditto/things/service/persistence/actors/ThingSupervisorActor.java
Show resolved
Hide resolved
Signed-off-by: Stanchev Aleksandar <aleksandar.stanchev@bosch.io>
alstanchev
force-pushed
the
feature/atomic-thing-create
branch
from
01737fb to
594ac98
Compare
thjaeckle
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Hey @alstanchev
That looks great - I had a look at the changes + the tests and are confident that improves resiliency a lot.
Good stuff 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds atomic behaviour to the creation of thing and its policy.
In the rare case of failing to create a thing, its policy will be rolled back (deleted) in order to not fail create retry.