don't use WARN log level when no policy is rolled back #1604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a lot of "WARN" logs in the Ditto 3.2.0 release cause by the new "rollback policy on thing exception error during thing creation" stabilization done in #1581
I think a "WARNING" should only be logged if the policy is actually rolled back (deleted again).
Currently, it is always logged if e.g. the following 2 exception happen during thing creation:
If-Match
orIf-None-Match
headers were set to do a "conditional create" only if the thing does not yet existFor those cases, I would not like to see a WARNING in the logs.
So I changed the log level to info instead and added another WARNING log when the policy is actually rolled back.
@alstanchev could you please have a look?