Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity Hub: reduce visibility of test fields #14

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Identity Hub: reduce visibility of test fields #14

merged 10 commits into from
Jul 28, 2022

Conversation

marcgs
Copy link
Contributor

@marcgs marcgs commented Jul 28, 2022 •
edited
Loading

What this PR changes/adds

Reduce visibility of test fields for consistency with EDC code.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@marcgs marcgs self-assigned this Jul 28, 2022
@marcgs marcgs force-pushed the feature/private-test-fields branch from 0222032 to 8b6741b Compare July 28, 2022 12:56
@marcgs marcgs marked this pull request as ready for review July 28, 2022 13:00
@paullatzelsperger paullatzelsperger merged commit 7c6908f into eclipse-edc:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

Assignees

@marcgs marcgs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcgs @paullatzelsperger