Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the format of the credentials returned by the IdentityHubCredentialsVerifier #17

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Document the format of the credentials returned by the IdentityHubCredentialsVerifier #17

merged 1 commit into from
Aug 9, 2022

Conversation

ouphi
Copy link
Contributor

@ouphi ouphi commented Aug 5, 2022 •
edited
Loading

What this PR changes/adds

Document the content of the Map<String, Object> returned by the IdentityHubCredentialsVerifier.

Further notes

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ouphi @algattik
Document the format of the credentials returned by the IdentityHubCre…
40cc6ee 
…dentialsVerifier. (#36)

* Documented claims format.

* improved explanations.

* Update docs/developer/decision-records/2022-07-01-get-claims/README.md

Co-authored-by: Alexandre Gattiker <algattik@users.noreply.github.com>

* Added subject in doc.

* Made the json format valid.

* Added information about the credentialSubject field.

* Added @code.

* Used pre .

Co-authored-by: Alexandre Gattiker <algattik@users.noreply.github.com>
@ouphi ouphi marked this pull request as ready for review August 5, 2022 14:27
@ouphi ouphi requested a review from paullatzelsperger August 5, 2022 14:27
@paullatzelsperger paullatzelsperger merged commit 0e22ee7 into eclipse-edc:main Aug 9, 2022
@ouphi ouphi mentioned this pull request Aug 9, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouphi @paullatzelsperger