Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release http(content)/http2(frame) bytebuf to prevent memory leak #3968

Closed
wants to merge 4 commits into from
Closed

Release http(content)/http2(frame) bytebuf to prevent memory leak #3968

wants to merge 4 commits into from

Conversation

lcybo
Copy link

@lcybo lcybo commented Oct 14, 2018

As the last handler that accessed the http data(bytebuf), Jersey handler has the responsibility to release them.
That require support for releaseOnClose in ByteBufInputStream since 4.1.7.Final.
Drop by to construct http2 pipeline via builder style.(detail)
Bump the version of netty to 4.1.30.Final.

…emory leak.

Signed-off-by: Chuanyi Li <chuanyili0625@gmail.com>
…emory leak.

Signed-off-by: Chuanyi Li <chuanyili0625@gmail.com>
…emory leak.

Signed-off-by: Chuanyi Li <chuanyili0625@gmail.com>
@jansupol
Copy link
Contributor

Filed CQ for Netty 4.1.31

Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no valid ECA on file for chuanyili0625@gmail.com. Can you please sign the ECA?

Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@010gvr
Copy link
Contributor

010gvr commented Nov 8, 2019

@lcybo @jansupol Not sure if this PR is still actively being monitored. But adding ChannelHandlerContext to a data processing class (NettyInputStream) feels a bit out of scope. Also, further load testing of current implementation revealed even more problems with JerseyChunkedInput and built in buffers leading to timeout and other related overheads. I've addressed several of these in #4312 which may be a permanent fix to all of netty/jersey issues that has been tested at a large-scale production use.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants