Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewritten Netty Jersey implementation using direct ByteBuf consumption #4312

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Rewritten Netty Jersey implementation using direct ByteBuf consumption #4312

merged 1 commit into from
Nov 29, 2019

Conversation

010gvr
Copy link
Contributor

@010gvr 010gvr commented Nov 6, 2019 •
edited
Loading

This commit contains a rewritten implementation of Netty Jersey server and client with the following major changes:

  1. Consume ByteBufs from HttpContent as-is for processing, reduces a lot of overhead.
  2. Fixes a bug on reading 0-byte or 1-byte JSON content
  3. Add three new configurable ChunkedInput buffer properties through jersey.ci.capacity, jersey.ci.read.timeout and jersey.ci.write.timeout
  4. Add configurable payload size through jersey.max.http.request.entitySizeMb , defaults to 50 Mb

This change should fix some of the long pending bug reports in #3500 , #3568 and #4286 . This may also resolve #4285

Signed-off-by: Venkat Ganesh 010gvr@gmail.com

@010gvr 010gvr force-pushed the feat/netty-bytebuf branch 2 times, most recently from dc2c3c7 to 9e9a096 Compare November 6, 2019 16:21
@010gvr
Rewritten Netty Jersey implementation using direct ByteBuf consumption
30dbb3e 
Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
@010gvr
Copy link
Contributor Author

010gvr commented Nov 6, 2019

Any interest in this?

@010gvr 010gvr mentioned this pull request Nov 8, 2019
Closed
@senivam senivam merged commit 8dcfed4 into eclipse-ee4j:master Nov 29, 2019
010gvr pushed a commit to 010gvr/jersey that referenced this pull request Nov 30, 2019
Unit tests for Jersey Netty Http Container
6b16add 
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler`.

Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312)

Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568

Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
010gvr pushed a commit to 010gvr/jersey that referenced this pull request Nov 30, 2019
Unit tests for Jersey Netty Http Container
d5b2a87 
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`.

Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312)

Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568

Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
010gvr pushed a commit to 010gvr/jersey that referenced this pull request Nov 30, 2019
Unit tests for Jersey Netty Http Container
563f7ce 
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`.

Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312)

Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568

Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
@010gvr 010gvr mentioned this pull request Nov 30, 2019
Open
010gvr added a commit to 010gvr/jersey that referenced this pull request Nov 30, 2019
@010gvr
Unit tests for Jersey Netty Http Container
80eeb04 
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`.

Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312)

Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568

Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
@010gvr 010gvr deleted the feat/netty-bytebuf branch November 30, 2019 16:24
010gvr added a commit to 010gvr/jersey that referenced this pull request Nov 30, 2019
@010gvr
Unit tests for Jersey Netty Http Container
e1b08df 
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`.

Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312)

Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568

Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
010gvr added a commit to 010gvr/jersey that referenced this pull request Dec 1, 2019
@010gvr
Unit tests for Jersey Netty Http Container
0987c2a 
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`.

Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312)

Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568

Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
010gvr added a commit to 010gvr/jersey that referenced this pull request Dec 1, 2019
@010gvr
Unit tests for Jersey Netty Http Container
522977f 
Current unit tests only validate Netty's `JerseyClientHandler` against a Grizzly http server. This commit adds test cases to validate the same using Netty's `JerseyServerHandler` using `NettyTestContainerFactory`.

Also adding extra test cases to effectively validate the bug fixes for eclipse-ee4j#3500 and eclipse-ee4j#3568 (that is, these new test cases will fail if ran against the code base older than eclipse-ee4j#4312)

Fixes eclipse-ee4j#3500 and eclipse-ee4j#3568

Signed-off-by: Venkat Ganesh <010gvr@gmail.com>
@jansupol jansupol added this to the 2.30 milestone Dec 16, 2019
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Aug 30, 2021
Closed
Merged
Merged
This was referenced Oct 21, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Feb 5, 2022
Closed
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
@renovate renovate bot mentioned this pull request Apr 19, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@jansupol jansupol jansupol approved these changes

Assignees

@senivam senivam

Labels
None yet
Projects
None yet
Milestone
2.30
Development

Successfully merging this pull request may close these issues.

Netty Connector's JerseyClientHandler should defer notification for arriving content
3 participants
@010gvr @jansupol @senivam