Skip to content

Conversation

@romain-grecourt
Copy link
Member

Pom fixes for things that break the GlassFish integration currently.

Signed-off-by: Romain Grecourt <romain.grecourt@oracle.com>
…sired dependency management

Signed-off-by: Romain Grecourt <romain.grecourt@oracle.com>
Signed-off-by: Romain Grecourt <romain.grecourt@oracle.com>
Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know @senivam made that bom pom to have jersey pom as a parent...Was it just to inherit the version?

@jansupol jansupol requested a review from senivam December 21, 2018 03:14
@senivam
Copy link
Contributor

senivam commented Dec 21, 2018

@jansupol no, it was done because of release process - when a new version was set (a project version was modified generally) using maven versions plugin, Jersey failed to compile any more due to inconsistency in the project which appeared after bom/pom.xml project version was changed. So I've asked if it's possible to modify bom's parent (as soon as I was not sure what more it will break). After short 3 hours discussion I was allowed to do that so I've submitted a PR to Jersey which was approved and release was fixed. However as appears now this breaks GF integrasion, so I will try to solve inconsistency in some other way. BTW, I suppose after this PR is merged release will be for some time unavailable.

@senivam senivam merged commit 180f1be into eclipse-ee4j:EE4J_8 Dec 21, 2018
@romain-grecourt
Copy link
Member Author

One of the problems that I'm aware of is that the bom pom is not processed by the reactor ordering resolution.

I saw that jersey uses it in the tests and example that could be the underlying problem.
This assumption could be wrong though since it worked before.

@senivam
Copy link
Contributor

senivam commented Dec 21, 2018

@romain-grecourt I've already solved that problem (bom is not in reactor) in the release job, I suppose finally release will work as it is supposed to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants