-
Notifications
You must be signed in to change notification settings - Fork 368
Adding maven ci friendly versions #5992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+444
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
senivam
approved these changes
Oct 2, 2025
Author
|
Awesome! Thank you @senivam. We started using cifriendly versions last year in our project too. It'll be great if the revision property name can be configurable. |
1 task
This was referenced Nov 5, 2025
Closed
This was referenced Nov 8, 2025
Update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v4
apache/solr#3137
Open
This was referenced Nov 9, 2025
1 task
This was referenced Nov 10, 2025
Open
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These changes for Maven cifriendly versions aren't really needed but should help avoid large diffs when changing snapshot versions.
I made the changes in the 4.0 branch. Please let me know if I need to do it in the default 2.x or another branch.
I initially changed the parent of the bom to the root but I see why the bom parent is different from the root parent after looking at #4013. Due to this, the flatten configuration needed to be added in the bom module too. So, snapshot version changes only need to happen in two places, the parent and bom modules.
If you would like pluginConfiguration for flatten-maven-plugin to be added in the ee4j parent, I can do that too. It'll avoid all the configuration being repeated twice here.