Skip to content

Conversation

@cmakinen
Copy link

Hi,

These changes for Maven cifriendly versions aren't really needed but should help avoid large diffs when changing snapshot versions.

I made the changes in the 4.0 branch. Please let me know if I need to do it in the default 2.x or another branch.

I initially changed the parent of the bom to the root but I see why the bom parent is different from the root parent after looking at #4013. Due to this, the flatten configuration needed to be added in the bom module too. So, snapshot version changes only need to happen in two places, the parent and bom modules.

If you would like pluginConfiguration for flatten-maven-plugin to be added in the ee4j parent, I can do that too. It'll avoid all the configuration being repeated twice here.

@senivam
Copy link
Contributor

senivam commented Oct 2, 2025

Thank you @cmakinen, the PR looks great! Having it, I've introduced the 487 PR to the flatten-maven-plugin to have the revision variable name configurable. Anyway, I think we can merge this PR as is and (if required) play with the revision variable name.

@cmakinen
Copy link
Author

cmakinen commented Oct 2, 2025

Awesome! Thank you @senivam. We started using cifriendly versions last year in our project too. It'll be great if the revision property name can be configurable.

@senivam senivam merged commit 72aad86 into eclipse-ee4j:4.0 Oct 8, 2025
10 of 14 checks passed
@senivam senivam added this to the 4.0.0 milestone Oct 8, 2025
This was referenced Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants