-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(flaky): Sorting headers for deterministic order #5754
Merged
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
approved these changes
Oct 3, 2024
senivam
approved these changes
Oct 3, 2024
1 task
This was referenced Dec 21, 2024
This was referenced Jan 8, 2025
1 task
1 task
1 task
1 task
This was referenced Feb 3, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 9, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of HTTP methods in the
ALLOW
header (OPTIONS,PUT vs PUT,OPTIONS) is not guaranteed to be consistent ingetHeaderString()
, so the following test case fails if the order changes:jersey/tests/e2e/src/test/java/org/glassfish/jersey/tests/e2e/server/wadl/NoJAXBNoWadlTest.java
Line 69 in 89de7de
This PR proposes to sort the headers so that the order assumptions (in this PR, alphabetical order) in the test cases are correct.
This change was confirmed by running the NonDex tool, which explores and reports errors in different behaviors of under-determined Java APIs.
To reproduce this problem, you can run the test with NonDex using these commands:
Here are screenshots of the output produced by NonDex before and after the fix:
Please let me know if you want to discuss these changes.