Migrate p2 engine to agent properties #439
Conversation
There was a problem hiding this comment.
It seems okay. But it causes one deprecation warning in Oomph for the phase set factory changes. I can't actually get rid of it by using the new method because I need to be able to run in older IDEs. I can't safely ignore the warning either because it's marked for removal. I could use reflection, but that is also ugly and error prone. So mostly I'm stuck with an ugly problem for which there are only ugly solutions.
There isn't a single iota of documentation to explain why I must use the new improved method. In fact, the deprecation doesn't even document which method should be used instead, nor even an indication when the removal will happen (no since). There's nothing the in Javadoc to suggest the agent could be null and why the agent is needed at all. If there is going to be disruptive change, the documentation should be better.
See eclipse-equinox/p2#439 Fix #3437 (cherry picked from commit 87563c6)
See eclipse-equinox/p2#439 Fix #3437 (cherry picked from commit 87563c6)
laeubi
force-pushed
the
migrate_engine_to_agent_props
branch
from
08d7135 to
53aec3d
Compare
laeubi
force-pushed
the
migrate_engine_to_agent_props
branch
4 times, most recently
from
c7bdbd3 to
3bca248
Compare
|
@merks I was now able to rework this even without any deprecations! |
laeubi
force-pushed
the
migrate_engine_to_agent_props
branch
from
3bca248 to
b1d0dc1
Compare
Now that agent properties are possible we should use them in the engine, to not rely on only static OSGi context properties.
laeubi
force-pushed
the
migrate_engine_to_agent_props
branch
from
b1d0dc1 to
6397aad
Compare
Now that agent properties are possible we should use them in the engine, to not rely on only static OSGi context properties.