Build I20240210-1800 is unstable

[iloveeclipse]

See

• https://download.eclipse.org/eclipse/downloads/drops4/I20240210-1800/
• https://download.eclipse.org/eclipse/downloads/drops4/I20240210-1800/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

Comparator differences from current build
	/home/jenkins/agent/workspace/Builds/I-build-4.31/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/siteDir/eclipse/downloads/drops4/I20240210-1800
compared to reference repo at 
	https://download.eclipse.org/eclipse/updates/4.31-I-builds

1.  eclipse.pde/ui/org.eclipse.pde.core/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/internal/core/P2Utils.class: different
      org/eclipse/pde/internal/core/target/P2TargetUtils.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

2.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.operations/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/p2/operations/ProvisioningSession.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

3.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.reconciler.dropins/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/internal/p2/reconciler/dropins/ProfileSynchronizer.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

4.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.director.app/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/internal/p2/director/app/DirectorApplication.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

5.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/internal/p2/ui/sdk/scheduler/AutomaticUpdater.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

With the most recent IBuild the list is slightly smaller, but basically in same area:

Comparator differences from current build
	/home/jenkins/agent/workspace/Builds/I-build-4.31/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/siteDir/eclipse/downloads/drops4/I20240211-1800
compared to reference repo at 
	https://download.eclipse.org/eclipse/updates/4.31-I-builds

1.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.operations/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/p2/operations/ProvisioningSession.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

2.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.reconciler.dropins/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/internal/p2/reconciler/dropins/ProfileSynchronizer.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

3.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.director.app/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/internal/p2/director/app/DirectorApplication.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

4.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/internal/p2/ui/sdk/scheduler/AutomaticUpdater.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

Looking on affected bundles only (without checking bytecode) I assume this equinox p2 change could cause that.

I'm looking into.

[iloveeclipse]

OK, my assumption was correct, eclipse-equinox/p2#439 is the root cause.

Few org.eclipse.equinox.p2.engine.PhaseSetFactory static fields were made final so compiler optimized the code and inlined constant in the bytecode instead of accessing field value every time in other bundles referring to this fields.

I will push a PR touching affected bundles.

[iloveeclipse]

Triggered new IBuild: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/133/

[iloveeclipse]

https://download.eclipse.org/eclipse/downloads/drops4/I20240212-0420/ is stable again.