GLSP-77: Allow WebSocket connections to reconnect after interrupt #269
Conversation
- Introduce GLSPWebSocketProvider to allow websocket connections to reconnect after interrupt - Make use of ws provider in standalone example Part of eclipse-glsp/glsp#77
packages/protocol/src/client-server-protocol/jsonrpc/ws-connection-provider.ts
Outdated
Show resolved
Hide resolved
packages/protocol/src/client-server-protocol/jsonrpc/ws-connection-provider.ts
Outdated
Show resolved
Hide resolved
packages/protocol/src/client-server-protocol/jsonrpc/ws-connection-provider.ts
Outdated
Show resolved
Hide resolved
| } | ||
| }) | ||
| ); | ||
| actionDispatcher.dispatch(RequestTypeHintsAction.create()); | ||
| await actionDispatcher.onceModelInitialized(); | ||
| actionDispatcher.dispatch(EnableToolPaletteAction.create()); | ||
|
|
||
| if (isReconnecting) { | ||
| const message = `Connection to the ${id} glsp server got closed. Connection was successfully re-established.`; |
There was a problem hiding this comment.
Offtopic: Dispatching ServerStatusActions or ServerMessageActions on the client side seems a bit weird.
In general, these actions are just plain status or message notifications and don't have to necessarily come from the server. Maybe we should consider a rename here to a more generic StatusAction and MessageAction or at the very least make it clear in the documentation that this actions can also be dispatched from the client side.
@planger WDYT?
There was a problem hiding this comment.
True, I'm in favor of a rename to StatusAction and MessageAction. However, I don't consider this a high prio.
There was a problem hiding this comment.
Me neither, nevertheless we should probably do it as part of the 2.0 Release. It' an API break after all, even if its just a minor one.
There was a problem hiding this comment.
Sounds good, I'll create an issue for this.
There was a problem hiding this comment.
|
Thanks Nina. Very promising change. I only had time for a code review for now. Will do some testing on Monday. |
Part of eclipse-glsp/glsp#77
Related to: eclipse-glsp/glsp-server-node#54
Related to: eclipse-glsp/glsp-server#208
Testing:
issues/77-testing. This automatically interrupts the example twice with an timeout of 5s in between.