GH-622 Fix Windows pathing issues + clean up #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consume a fix for OS-independent file path handling. (eclipse-glsp/glsp-theia-integration#116) - Update glsp-theia-integration version - Update to Theia 1.25 - Update Readmes Part of eclipse-glsp/glsp#561
Consistently use `TaskList` over `Tasklist` in all project templates
planger
approved these changes
May 30, 2022
There was a problem hiding this comment.
Thanks a lot! Looks good to me. I tested the node-json-theia, node-json-vscode and java-emf-theia examples.
Just a few suggestions inline.
Also I saw that my yarn.lock files are changed after the build here:
"@lerna/resolve-symlink@4.0.0":
version "4.0.0"
resolved "https://registry.yarnpkg.com/@lerna/resolve-symlink/-/resolve-symlink-4.0.0.tgz#6d006628a210c9b821964657a9e20a8c9a115e14"
integrity sha512-RtX8VEUzqT+uLSCohx8zgmjc6zjyRlh6i/helxtZTMmc4+6O4FS9q5LJas2uGO2wKvBlhcD6siibGt7dIC3xZA==
dependencies:
fs-extra "^9.1.0"
npmlog "^4.1.2"
read-cmd-shim "^2.0.0"
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Weird. I have rebuilt all three project templates locally and for me the yarn lock does not change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume a fix for OS-independent file path handling. (GH-561 Fix file path handling for Windows glsp-theia-integration#116)
TaskListprefix of classes in all project templates