GH-561 Fix file path handling for Windows #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to Theia 1.25 to make use of the new `Uri.path.fsPath()` method which should ensure consistent file URI paths independent of the underlying OS. FIxes eclipse-glsp/glsp#561
planger
approved these changes
May 25, 2022
|
Hello, thank you for your work |
tortmayr
added a commit
to eclipse-glsp/glsp-examples
that referenced
this pull request
May 28, 2022
Consume a fix for OS-independent file path handling. (eclipse-glsp/glsp-theia-integration#116) - Update glsp-theia-integration version - Update to Theia 1.25 Part of eclipse-glsp/glsp#561
tortmayr
added a commit
to eclipse-glsp/glsp-examples
that referenced
this pull request
May 29, 2022
Consume a fix for OS-independent file path handling. (eclipse-glsp/glsp-theia-integration#116) - Update glsp-theia-integration version - Update to Theia 1.25 - Update Readmes Part of eclipse-glsp/glsp#561
tortmayr
added a commit
to eclipse-glsp/glsp-examples
that referenced
this pull request
May 30, 2022
* #622 Update theia project templates Consume a fix for OS-independent file path handling. (eclipse-glsp/glsp-theia-integration#116) - Update glsp-theia-integration version - Update to Theia 1.25 - Update Readmes Part of eclipse-glsp/glsp#561 * Add sub-readmes and update tasks and launch config * Align `TaskList` prefix in source files Consistently use `TaskList` over `Tasklist` in all project templates Co-authored-by: Philip Langer <planger@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Theia 1.25 to make use of the new
Uri.path.fsPath()method which should ensure consistent file URI paths independent of the underlyingOS.
FIxes eclipse-glsp/glsp#561