-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0.0] GLSP client breaks when opening multiple diagrams #1181
Comments
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Nov 29, 2023
Fixes eclipse-glsp/glsp#1181 Also: Update changelog to reflect latest changes
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Nov 29, 2023
Fixes eclipse-glsp/glsp#1181 Also: Update changelog to reflect latest changes
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Nov 30, 2023
Fixes eclipse-glsp/glsp#1181 Also: Update changelog to reflect latest changes
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this issue
Dec 21, 2024
…#307) Fixes eclipse-glsp/glsp#1181 Also: Update changelog to reflect latest changes
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this issue
Dec 21, 2024
…#307) Fixes eclipse-glsp/glsp#1181 Also: Update changelog to reflect latest changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Opening multiple diagrams (associated with the same GLSP client) breaks the GLSPClient.onActionMessage notification and only the last opened diagram will still receive messages from the server.
The issue is that we directly hook to the
connection.OnNotification(..)
method from vscode-jsonrpc which infact can only handle one listener. Registering a new listener by opening a new diagram will override any existing listener.To fix this we should introduce an intermediate event emitter that is hooked to the connections
onNotification
methods. Any listeners registered withGLSPClient.onActionMessage
will then be registered on that emitter.The text was updated successfully, but these errors were encountered: