Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.0] GLSP client breaks when opening multiple diagrams #1181

Closed
tortmayr opened this issue Nov 29, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-client#307
Closed

[2.0.0] GLSP client breaks when opening multiple diagrams #1181

tortmayr opened this issue Nov 29, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-client#307
Labels
bug Something isn't working critical

Comments

@tortmayr
Copy link
Contributor

Opening multiple diagrams (associated with the same GLSP client) breaks the GLSPClient.onActionMessage notification and only the last opened diagram will still receive messages from the server.
The issue is that we directly hook to the connection.OnNotification(..) method from vscode-jsonrpc which infact can only handle one listener. Registering a new listener by opening a new diagram will override any existing listener.
To fix this we should introduce an intermediate event emitter that is hooked to the connections onNotification methods. Any listeners registered with GLSPClient.onActionMessage will then be registered on that emitter.

@tortmayr tortmayr added bug Something isn't working critical labels Nov 29, 2023
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Nov 29, 2023
Fixes  eclipse-glsp/glsp#1181

Also: Update changelog to reflect latest changes
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Nov 29, 2023
Fixes  eclipse-glsp/glsp#1181

Also: Update changelog to reflect latest changes
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Nov 30, 2023
Fixes  eclipse-glsp/glsp#1181

Also: Update changelog to reflect latest changes
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant