Download java sources lazily for Maven projects #986
Conversation
| * @throws JavaModelException | ||
| * @throws CoreException | ||
| */ | ||
| default void getSource(IClassFile classFile, IProgressMonitor monitor) throws CoreException { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| /** | ||
| * @author Fred Bricon | ||
| * | ||
| */ | ||
| public class MavenBuildSupport implements IBuildSupport { | ||
|
|
||
| private static final int MAX_WAIT_MILLIS = 3000; | ||
| private static Cache<String, Boolean> cache = CacheBuilder.newBuilder().maximumSize(100).expireAfterWrite(1, TimeUnit.HOURS).build(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -76,4 +78,17 @@ default void refresh(IResource resource, CHANGE_TYPE changeType, IProgressMonito | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * download source | |||
There was a problem hiding this comment.
You're actually discovering AND attaching the source
| IClasspathManager buildpathManager = MavenJdtPlugin.getDefault().getBuildpathManager(); | ||
| buildpathManager.scheduleDownload(fragment, true, true); | ||
| waitForDownload(monitor); | ||
| buildpathManager.scheduleDownload(project, true, true); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@fbricon I have updated the PR. |
fbricon
changed the title
| } | ||
| } | ||
|
|
||
| private void waitForDownload(IProgressMonitor monitor) { |
There was a problem hiding this comment.
Use JobHelpers.waitForJobs(IJobMatcher)
| IClasspathManager buildpathManager = MavenJdtPlugin.getDefault().getBuildpathManager(); | ||
| buildpathManager.scheduleDownload(fragment, true, true); | ||
| waitForDownload(monitor); | ||
| downloadRequestsCache.put(path.toString(), true); |
There was a problem hiding this comment.
move before buildpathManager.scheduleDownload(fragment, true, true); else you might get simultaneous multiple download attempts
| IJavaProject javaProject = JavaCore.create(project); | ||
| IType type = javaProject.findType("org.apache.commons.lang3.StringUtils"); | ||
| IClassFile classFile = ((BinaryType) type).getClassFile(); | ||
| assertTrue(classFile.getBuffer() == null); |
| waitForJobs(DownloadSourcesJobMatcher.INSTANCE, WAIT_FOR_DOWNLOAD_SOURCE_JOB_MILLIS); | ||
| } | ||
|
|
||
| public static void waitForDownloadSourcesJobsTest() { |
There was a problem hiding this comment.
no, this class shouldn't have test specific methods. I'd rather prefer you added
public static void waitForDownloadSourcesJobs(int maxWaitMillis)
| @@ -76,4 +78,17 @@ default void refresh(IResource resource, CHANGE_TYPE changeType, IProgressMonito | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * discover source | |||
There was a problem hiding this comment.
Discover the source for classFile and attach it to the project it belongs to.
| * - a class file | ||
| * @param monitor | ||
| * - a progress monitor | ||
| * @throws JavaModelException |
There was a problem hiding this comment.
JavaModelException is not in the signature
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@fbricon I have updated the PR. |
Fixes #979
Requires redhat-developer/vscode-java#870
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com