Download java sources lazily #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Apr 8, 2019
README.md
Outdated
| @@ -103,6 +103,9 @@ The following settings are supported: | |||
| *New in 0.42.0:* | |||
| * `java.foldingRange.enabled`: Enable/disable smart folding range support. If disabled, it will use the default indentation-based folding range provided by VS Code. | |||
|
|
|||
| *New in 0.43.0:* | |||
| * `java.maven.downloadSources`: Enable/disable downloading Maven source artifacts. | |||
There was a problem hiding this comment.
Enable/disable eager download of Maven source artifacts
fbricon
reviewed
Apr 8, 2019
package.json
Outdated
| "java.maven.downloadSources": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "Enable/disable downloading Maven source artifacts.", |
There was a problem hiding this comment.
Enable/disable eager download of Maven source artifacts
|
@fbricon I have updated the PR. |
fbricon
reviewed
Apr 8, 2019
README.md
Outdated
| @@ -103,6 +103,9 @@ The following settings are supported: | |||
| *New in 0.42.0:* | |||
| * `java.foldingRange.enabled`: Enable/disable smart folding range support. If disabled, it will use the default indentation-based folding range provided by VS Code. | |||
|
|
|||
| *New in 0.43.0:* | |||
| * `java.maven.downloadSources`: Enable/disable downloading Maven source artifacts on startup. | |||
There was a problem hiding this comment.
Enable/disable eager download of Maven source artifacts
sorry, I changed my mind earlier and you missed my comment update
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires eclipse-jdtls/eclipse.jdt.ls#986
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com