Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse KubernetesResourceUtil ConfigMap utils methods #2186

Closed
manusa opened this issue May 31, 2023 · 0 comments · Fixed by #2424
Closed

Reuse KubernetesResourceUtil ConfigMap utils methods #2186

manusa opened this issue May 31, 2023 · 0 comments · Fixed by #2424
Assignees
@rohanKanojia
Labels
technical-debt
Milestone
1.15.0

Comments

@manusa
Copy link
Member

manusa commented May 31, 2023

Description

Now that fabric8io/kubernetes-client#4184 and fabric8io/kubernetes-client#5173 have been merged, let's reuse these methods and remove the JKube implementations.
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Oct 18, 2023
@rohanKanojia
refactor (jkube-kit/enricher) : Reuse Fabric8 KubernetesResourceUtil …
5288daf 
…ConfigMap utils methods (eclipse-jkube#2186)

+ Remove deprecated methods of `org.eclipse.jkube.kit.enricher.api.util.KubernetesResourceUtil`
+ Update ConfigMapEnricher to use `io.fabric8.kubernetes.client.utils.KubernetesResourceUtil`

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Oct 18, 2023
Merged
17 tasks
@manusa manusa added this to the 1.15.0 milestone Oct 19, 2023
manusa pushed a commit that referenced this issue Oct 19, 2023
@rohanKanojia @manusa
refactor (jkube-kit/enricher) : Reuse Fabric8 KubernetesResourceUtil …
56c80d9 
…ConfigMap utils methods (#2186)

+ Remove deprecated methods of `org.eclipse.jkube.kit.enricher.api.util.KubernetesResourceUtil`
+ Update ConfigMapEnricher to use `io.fabric8.kubernetes.client.utils.KubernetesResourceUtil`

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Feb 22, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
technical-debt
Projects
None yet
Milestone
1.15.0
2 participants
@manusa @rohanKanojia