feat (kubernetes-client) : Add utility methods to KubernetesResourceUtil for creating ConfigMap from file (#4184) #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m file (fabric8io#4184) + Added ConfigMapResource for modifying default ConfigMap operations + Added FromFileCreatable DSL method to provide file + Move KubernetesResourceUtilTest to `io.fabric8.kubernetes.client.utils` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
+ fromFile(key, path) can be chained in order to construct a ConfigMap with entries from different files + Move fromFile operation a level up so that it's available from `client.configMaps()` interface directly. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…etes-client into rohanKanojia-pr/issue4184
now that we're considering allowing for the modification of the current item, and not just create, this makes the api more consistent with the rest of the dsl
rohanKanojia-pr/issue4184
rohanKanojia-pr/issue4184
shawkins
requested review from
manusa,
oscerd,
rohanKanojia and
sunix
as code owners
shawkins
force-pushed
the
rohanKanojia-pr/issue4184
branch
from
d8a6b2e
to
cce7e2e
Compare
rohanKanojia
approved these changes
May 29, 2023
11 tasks
rohanKanojia
changed the title
manusa
approved these changes
May 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4184
This is a pared down version of @rohanKanojia changes to move forward with just 2 helper methods on KubernetesResourceUtil.
This didn't want to merge cleanly into the existing pr, so I opened up another one.
Type of change
test, version modification, documentation, etc.)
Checklist