Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enricher for MicroProfile Health implementations #443

Open
4 tasks
manusa opened this issue Oct 20, 2020 · 4 comments
Open
4 tasks

Enricher for MicroProfile Health implementations #443

manusa opened this issue Oct 20, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@manusa manusa added the enhancement New feature or request label Oct 20, 2020
@manusa manusa added this to the 1.1.0 milestone Oct 20, 2020
@manusa manusa modified the milestones: 1.1.0, 1.2.0 Jan 18, 2021
@manusa
Copy link
Member Author

manusa commented Jan 20, 2021

Internal reference: [protean-dev] Philosophy around healthchecks

@sunix
Copy link
Member

sunix commented Apr 26, 2022

@rohanKanojia rohanKanojia self-assigned this Jun 3, 2022
@rohanKanojia
Copy link
Member

rohanKanojia commented Jun 24, 2022

I think we have health check implementations for the following Microprofile implementations:

In Microprofile Starter, I also see some other Microprofile runtimes for old versions of Microprofile (3.3):

Do we need to consider these runtimes as well? If yes, I'd create issues for these. Or can we ignore it since they're using an old version of Microprofile?

@manusa
Copy link
Member Author

manusa commented Aug 3, 2022

Considering we haven't released 1.9.0 yet, we might want to refactor + redocument what was done in #1541 (#1473).

As suggested in #1473 (comment), #1473 looks like a duplicate of this issue, however, it's coupled to OpenLiberty, when it probably shouldn't.

In addition, there are more artifacts that provide a MicroProfile health implementation.

Part of the scope of this issue is analyzing other implementations and see how we should add support for them.

@rohanKanojia rohanKanojia self-assigned this Aug 18, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 18, 2022
…ipse-jkube#443)

Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
probes if `io.smallrye:smallrye-health` is present in project
dependencies.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 19, 2022
…ipse-jkube#443)

Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
probes if `io.smallrye:smallrye-health` is present in project
dependencies.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 19, 2022
…ipse-jkube#443)

Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
probes if `io.smallrye:smallrye-health` is present in project
dependencies.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 19, 2022
…ipse-jkube#443)

+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 19, 2022
…ipse-jkube#443)

+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 19, 2022
…ipse-jkube#443)

+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 23, 2022
…ipse-jkube#443)

+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 2, 2022
…ipse-jkube#443)

+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 2, 2022
…ipse-jkube#443)

+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 4, 2022
…ipse-jkube#443)

+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Nov 7, 2022
+ Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup
  probes if `io.smallrye:smallrye-health` is present in project
  dependencies.
+ Moved common logic between SmallRyeHealthCheckEnricher and
  OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants