feat (jkube-kit) : Add health check enricher for SmallRye Health (#443) #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1709 (2022-11-04T14:29:53Z) ⚙️ JKube E2E Tests (3394103477)
|
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
============================================
+ Coverage 53.05% 53.06% +0.01%
- Complexity 3943 3951 +8
============================================
Files 464 467 +3
Lines 20750 20763 +13
Branches 2808 2807 -1
============================================
+ Hits 11009 11018 +9
- Misses 8613 8616 +3
- Partials 1128 1129 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rohanKanojia
force-pushed
the
pr/issue443
branch
3 times, most recently
from
aa35cc6
to
bfb808d
Compare
rohanKanojia
force-pushed
the
pr/issue443
branch
from
bfb808d
to
efe08ae
Compare
|
Kudos, SonarCloud Quality Gate passed! |
rohanKanojia
force-pushed
the
pr/issue443
branch
3 times, most recently
from
e8de8de
to
6f95e3e
Compare
manusa
reviewed
Nov 4, 2022
| private static String getMicroProfileVersionFromArtifactId(JavaProject javaProject, String artifactId) { | ||
| Dependency microProfileDep = JKubeProjectUtil.getDependency(javaProject, MICROPROFILE_GROUP, artifactId); | ||
| private static String getMicroProfileVersionFromArtifactId(JavaProject javaProject, String groupId, String artifactId) { | ||
| Dependency microProfileDep = JKubeProjectUtil.getTransitiveDependency(javaProject, groupId, artifactId); |
There was a problem hiding this comment.
Just to double check, this does work with Gradle right?
(The question is redundant since I see the IT, but it's best if we keep your confirmation to this comment as a record in case there are doubts in the future)
There was a problem hiding this comment.
I've checked again with my test projet. It seems to be working okay.
manusa
approved these changes
Nov 4, 2022
|
I'd expect this Enricher also affecting Quarkus, but I didn't see any changes in that module. |
Right now enrichers are executed in the order specified in profiles-default.yml: I've placed SmallRyeHealthCheckEnricher at the bottom. Once an enricher adds liveness/readiness probes other health check enrichers would simply ignore it. The logic is to add probes only if they don't exist. |
This is very brittle (especially since there is no test right now to verify the possible permutations and their effects, or is there?) |
…ipse-jkube#443) + Add SmallRyeHealthCheckEnricher to add readiness, liveness and startup probes if `io.smallrye:smallrye-health` is present in project dependencies. + Moved common logic between SmallRyeHealthCheckEnricher and OpenLibertyHealthCheckEnricher to `jkube-kit-microprofile` module Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…alth Add SmallRyeIT to verify readiness, liveness and startup probes are generated when `io.smallrye:smallrye-health` dependency is present in project Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…cher Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue443
branch
from
6f95e3e
to
4e6217b
Compare
|
I don't think there is any test to enforce enricher ordering. |
There isn't , but still relying just on the ordering of the config file is really dangerous. I'm not sure what the collisions between the new enricher and previous ones are, but we should make sure that only one of the applicable is applied via some sort of scoring system. |
|
Kudos, SonarCloud Quality Gate passed! |
|
I think we should tackle this in a separate issue. |
👍 Please create an issue with a summary and link to this PR+issue |
|
I've created #1890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #443
probes if
io.smallrye:smallrye-healthis present in projectdependencies.
OpenLibertyHealthCheckEnricher to
jkube-kit-microprofilemoduleSigned-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist