-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel any operation as soon as possible. #358
Comments
Please see the PR eclipse-lemminx/lemminx#1502 which provides the cancel checker in the Hover API participant. |
Shouldn't that issue be closed since #398 was merged? |
@fbricon I don't think so yet. There is still a number of participants to add cancellation checks or re-visited if they can be cancelled as soon as possible. |
@fbricon please note that it will not work on Eclipse IDE side since LSP4E client doesn't cancel the request. |
@vrubezhny I think we can close this issue? |
@angelozerr Yes, I believe the most of cancelling support is added, so we can close this issue. Thank you! |
Once LSP4E will support cancel support eclipse-lsp4e/lsp4e#431, it should be really nice to support cancel support on lemminx-maven side.
LemMinx support cancel support which stop any operation like XML completion, diagnostics as soon as possible. As vscode provides cancel support, we have a very good performance.
It misses only hover (see eclipse-lemminx/lemminx#1474)
It is very easy to support cancel support. For instance indefinition you receive the cancel checker https://github.com/eclipse/lemminx-maven/blob/dd3fe65991ad39cbf45c7f689a0a9e49500a4463/lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/participants/definition/MavenDefinitionParticipant.java#L52
and in long process you should call cancelChecker.checkedCanceled(); like in https://github.com/eclipse/lemminx-maven/blob/dd3fe65991ad39cbf45c7f689a0a9e49500a4463/lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/participants/definition/MavenDefinitionParticipant.java#L122
The text was updated successfully, but these errors were encountered: