Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel any operation as soon as possible. #358

Closed
angelozerr opened this issue Feb 1, 2023 · 6 comments
Closed

Cancel any operation as soon as possible. #358

angelozerr opened this issue Feb 1, 2023 · 6 comments
Assignees

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Feb 1, 2023

Once LSP4E will support cancel support eclipse-lsp4e/lsp4e#431, it should be really nice to support cancel support on lemminx-maven side.

LemMinx support cancel support which stop any operation like XML completion, diagnostics as soon as possible. As vscode provides cancel support, we have a very good performance.

It misses only hover (see eclipse-lemminx/lemminx#1474)

It is very easy to support cancel support. For instance indefinition you receive the cancel checker https://github.com/eclipse/lemminx-maven/blob/dd3fe65991ad39cbf45c7f689a0a9e49500a4463/lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/participants/definition/MavenDefinitionParticipant.java#L52

and in long process you should call cancelChecker.checkedCanceled(); like in https://github.com/eclipse/lemminx-maven/blob/dd3fe65991ad39cbf45c7f689a0a9e49500a4463/lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/participants/definition/MavenDefinitionParticipant.java#L122

@angelozerr
Copy link
Contributor Author

Please see the PR eclipse-lemminx/lemminx#1502 which provides the cancel checker in the Hover API participant.

@vrubezhny vrubezhny self-assigned this Apr 26, 2023
@vrubezhny vrubezhny moved this to In Progress in Java Tooling Apr 27, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 27, 2023

Verified

This commit was signed with the committer’s verified signature.
chiefmikey Mikl Wolfe
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023

Verified

This commit was signed with the committer’s verified signature.
chiefmikey Mikl Wolfe
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023

Verified

This commit was signed with the committer’s verified signature.
chiefmikey Mikl Wolfe
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023

Verified

This commit was signed with the committer’s verified signature.
chiefmikey Mikl Wolfe
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023

Verified

This commit was signed with the committer’s verified signature.
chiefmikey Mikl Wolfe
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 28, 2023
@vrubezhny vrubezhny removed the status in Java Tooling Apr 29, 2023
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Apr 30, 2023
@fbricon
Copy link
Contributor

fbricon commented May 25, 2023

Shouldn't that issue be closed since #398 was merged?

@vrubezhny
Copy link
Contributor

@fbricon I don't think so yet. There is still a number of participants to add cancellation checks or re-visited if they can be cancelled as soon as possible.

@angelozerr
Copy link
Contributor Author

angelozerr commented May 25, 2023

@fbricon please note that it will not work on Eclipse IDE side since LSP4E client doesn't cancel the request.

@angelozerr
Copy link
Contributor Author

@vrubezhny I think we can close this issue?

@vrubezhny
Copy link
Contributor

@angelozerr Yes, I believe the most of cancelling support is added, so we can close this issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants