Provide cancel support for hover #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-lemminx#1474 Signed-off-by: azerr <azerr@redhat.com>
|
It seems like |
datho7561
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
This appears to be working, I didn't run into any new bugs with hover when running this PR. Just to leave a note about this: hover requests are never cancelled in lemminx itself, but an extension onto lemminx, like lemminx-maven, might benefit from cancellation support. Thanks, Angelo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide cancel support for hover
Fixes #1474