Redirect stdio streams #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2020
fbricon
force-pushed
the
dont-write-to-sdout
branch
from
f6480ec
to
ace66c9
Compare
angelozerr
reviewed
Sep 14, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/logs/LogHelper.java
Outdated
Show resolved
Hide resolved
fbricon
force-pushed
the
dont-write-to-sdout
branch
2 times, most recently
from
b15d703
to
529ced7
Compare
angelozerr
reviewed
Sep 15, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/XMLServerLauncher.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Sep 15, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/XMLLanguageServer.java
Show resolved
Hide resolved
angelozerr
reviewed
Sep 15, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/XMLLanguageServer.java
Show resolved
Hide resolved
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
dont-write-to-sdout
branch
from
529ced7
to
765ae56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change prevents client-server from breaking when something (like lemminx-maven) writes to sdtout
However, we lose, for now the server startup output. That still needs to be fixed.