Allow globs in xml.javaExtensions
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works well with eclipse-lemminx/lemminx-maven#148 + eclipse-lemminx/lemminx#873 => vscode-xml-maven-0.2.0.vsix |
Paths supplied to `xml.javaExtensions` will be treated as globs. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
glob-extension-jars
branch
from
269900c
to
d4cd6e1
Compare
fbricon
approved these changes
Sep 11, 2020
|
@datho7561 neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths supplied to
xml.javaExtensionswill be treated as globs.To test, I took vscode-lemminx-maven, modified
xml.javaExtensionsinpackage.jsonto./jar/*.jar, then added the liquidbase lemminx extension uber into./jar. Bothpom.xmland this liquidbase example (first one) received validation:Signed-off-by: David Thompson davthomp@redhat.com