-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New timestamp format using BigDecimal and Instant #1313
New timestamp format using BigDecimal and Instant #1313
Conversation
@adamsero, looking at your PR, I see that github action does not work as expected. I create #1314 to try to resolve it. |
e31893b
to
5204ac9
Compare
@sbernard31 regarding your comment, specifically
I'm getting a bunch of errors caused by the use of <signature>
<groupId>net.sf.androidscents.signature</groupId>
<artifactId>android-api-level-19</artifactId>
<version>4.4.2_r4</version>
</signature> The fact that we check against API v19 released in 2013 means that we can't use any feature of Java 1.8 (from 2014), so we either have to bump the API version (I don't know what issues could arise from that) or this PR stays useless since I can't use the |
About Sorry I didn't think to check if this was available. I continue the discussion at #1304 |
After discussion at #1304 (comment). We decide to bump android API level from 19 to 26.
to something like
|
leshan-core/src/main/java/org/eclipse/leshan/core/util/TimestampUtil.java
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/util/TimestampUtil.java
Outdated
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/senml/ResolvedSenMLRecord.java
Outdated
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/node/codec/senml/LwM2mNodeSenMLEncoder.java
Outdated
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/senml/SenMLResolver.java
Outdated
Show resolved
Hide resolved
leshan-core/src/test/java/org/eclipse/leshan/core/node/TimestampedLwM2mNodesTest.java
Outdated
Show resolved
Hide resolved
leshan-core/src/test/java/org/eclipse/leshan/core/node/codec/LwM2mNodeEncoderTest.java
Outdated
Show resolved
Hide resolved
leshan-core/src/test/java/org/eclipse/leshan/core/node/codec/LwM2mNodeEncoderTest.java
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/util/TimestampUtil.java
Outdated
Show resolved
Hide resolved
We should be good now @sbernard31, waiting for you to bump the API version if you don't have any more issues to fix. |
leshan-core/src/main/java/org/eclipse/leshan/core/util/TimestampUtil.java
Outdated
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/util/TimestampUtil.java
Show resolved
Hide resolved
@sbernard31 I created some tests and added some exception throws in the util method. My question is, can we possibly be done with this PR and M9 by the end of the week? It would be really good timing if we could. |
leshan-core/src/test/java/org/eclipse/leshan/core/util/TimestampUtilTest.java
Show resolved
Hide resolved
leshan-core/src/test/java/org/eclipse/leshan/core/util/TimestampUtilTest.java
Outdated
Show resolved
Hide resolved
leshan-core/src/test/java/org/eclipse/leshan/core/util/TimestampUtilTest.java
Outdated
Show resolved
Hide resolved
We can try. |
...mo/src/main/java/org/eclipse/leshan/server/demo/servlet/json/JacksonLwM2mNodeSerializer.java
Outdated
Show resolved
Hide resolved
I think we are good now ? I let you deal with Then maybe you could rebase on `master and, squash all commits in one ? (then push force) Eventually you can Android level API change in a separated commit, if you do that then this android level api change commit should be before the modification. (but again it's ok if you squash all in 1) Last point, maybe you can refer #1304 issue in your commit header. |
024f4f7
to
2fdf9f1
Compare
Should be good to go. Good to finally see a green checkmark 🙂 |
Thx for the contribution 🙏 ! |
No description provided.