Add Checkstyle Rule to ensure Java File has Header #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
force-pushed
the
java_header
branch
from
c37bd17 to
a21df70
Compare
sbernard31
force-pushed
the
java_header
branch
from
a21df70 to
45cbe1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1313 (comment), I find a way to check Java file header with Checkstyle using RegexpHeader rule.
Seeing the number of bad/missing header in current code base 😱, I think we really need it 😅.
Note that, we currently don't check xml or javascript header but I guess could.
There is other maven plugins which could help and also provides goal to add header automatically. Not totally sure I feel the eclipse dual licenses could make their use not so easy :