Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in lookupScheme2 #7134

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

dylanjtuttle
Copy link
Contributor

@dylanjtuttle dylanjtuttle commented Oct 5, 2023

Remove code in static function lookupScheme2 dependent on boolean variable isInt64 which was hard-coded to false.

This also removes code that was causing a warning, so this PR also contributes to (but does not close) openj9 #14859

@dylanjtuttle
Copy link
Contributor Author

Henry @hzongaro, could you review when you have the time?

@dylanjtuttle dylanjtuttle changed the title Fix casts to ensure variables are wide enough to accommodate shifts Remove dead code in lookupScheme2 Oct 10, 2023
Copy link
Contributor

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct. Just a minor request to clean up some stray tab characters in the source.

compiler/p/codegen/ControlFlowEvaluator.cpp Outdated Show resolved Hide resolved
Remove code in static function lookupScheme2 dependent on
boolean variable isInt64 which was hard-coded to false at the
start of the function

Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
Copy link
Contributor

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Contributor

Jenkins build all

@hzongaro
Copy link
Contributor

x86-64 macOS failures appear to be due to issue #6516

34: [----------] 19 tests from PortSockTest
34: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1209: Failure
34:       Expected: rc
34:       Which is: 1
34: To be equal to: 2
34: [  FAILED  ] PortSockTest.poll_functionality_basic (1001 ms)
34: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:51: Failure
34:       Expected: privateOmrPortLibrary->sock_bind(privateOmrPortLibrary, *serverSocket, serverSockAddr)
34:       Which is: -506
34: To be equal to: 0
34: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1259: Failure
34:       Expected: privateOmrPortLibrary->sock_accept(privateOmrPortLibrary, serverSocket, &connectedServerSockAddr, &connectedServerSocket)
34:       Which is: -20
34: To be equal to: 0
34: [  FAILED  ] PortSockTest.poll_functionality_many_sockets (1 ms)

Of course, the only testing that was necessary for this change was plinux and aix, both of which were successful. Merging.

@hzongaro hzongaro merged commit 550f5de into eclipse-omr:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants