-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code in lookupScheme2 #7134
Conversation
Henry @hzongaro, could you review when you have the time? |
f809e80
to
0606e8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look correct. Just a minor request to clean up some stray tab characters in the source.
Remove code in static function lookupScheme2 dependent on boolean variable isInt64 which was hard-coded to false at the start of the function Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
0606e8d
to
37c6fbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Jenkins build all |
x86-64 macOS failures appear to be due to issue #6516
Of course, the only testing that was necessary for this change was plinux and aix, both of which were successful. Merging. |
Remove code in static function lookupScheme2 dependent on boolean variable isInt64 which was hard-coded to false.
This also removes code that was causing a warning, so this PR also contributes to (but does not close) openj9 #14859