Handle monitor enter/exit on value based instances (X86) #11358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzongaro Henry, could you help review this one? Thanks! |
a7ehuo
force-pushed
the
jep390-valuedbased-x86-2
branch
from
2d39bdb
to
3b44a9e
Compare
hzongaro
requested changes
Dec 8, 2020
a7ehuo
force-pushed
the
jep390-valuedbased-x86-2
branch
3 times, most recently
from
ea1a96f
to
a9e5929
Compare
|
Henry @hzongaro All comments addressed. Ready for another review. Thanks! |
|
@0xdaryl May I ask you to review this one? Thanks! |
0xdaryl
requested changes
Dec 14, 2020
a7ehuo
force-pushed
the
jep390-valuedbased-x86-2
branch
from
a9e5929
to
07845c8
Compare
Add `areValueBasedMonitorChecksEnabled` which calls VM to check if value based class monitor check is enabled. Add `isValueBasedClass` and `isMonitorValueBased` to determine if a monitor object is a value based class instance. Related to JEP390 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
If the monitor object type is value based class, VM will either issue a warning or throw an exception based on -XX:ValueBasedClassCheck option. If the monitor object type is unkonwn, insert a runtime memory check in monitor enter/exit on the class flag J9ClassIsValueBased. If the monitor object type is not value based class, proceed as how it is handled today. Value based class and value type are mutually exclusive. Related to JEP390 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
jep390-valuedbased-x86-2
branch
from
07845c8
to
881cddc
Compare
|
Jenkins test sanity,extended xlinuxval jdknext |
|
Jenkins test sanity all jdknext |
1 task
0xdaryl
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
areValueBasedMonitorChecksEnabledwhich calls VM to check if value based class monitor check is enabled.Add
isValueBasedClassandisMonitorValueBasedto determine if a monitor object is a value based class instance.If the monitor object type is value based class, VM will either issue a warning or throw an exception
based on
-XX:ValueBasedClassCheckoption.If the monitor object type is unkonwn, insert a runtime memory check in monitor enter/exit on the class flag
J9ClassIsValueBased.If the monitor object type is not value based class, proceed as how it is handled today.
Related to JEP390 #10620