Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle monitor enter/exit on value based instances in Power #11491

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Handle monitor enter/exit on value based instances in Power #11491

merged 1 commit into from
Jan 18, 2021

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Dec 16, 2020 •
edited
Loading

Depends on

Related to JEP390

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

@a7ehuo
Power: Handle monitor enter/exit on value based instances
81af61a 
Related to JEP390

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo changed the title WIP: Handle monitor enter/exit on value based instances in Power Handle monitor enter/exit on value based instances in Power Dec 21, 2020
@a7ehuo a7ehuo marked this pull request as ready for review December 21, 2020 16:04
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Dec 21, 2020

@gita-omr Ready to review, thanks!
@hzongaro FYI

@gita-omr
Copy link
Contributor

I am a bit puzzled since I think we already did this work. But will need to look after Jan 4th.

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Dec 22, 2020

The work done in #10214 is to check if monitor enter/exit is on value type instances. This change is to check if monitor enter/exit is on value based class objects. A new @ValueBased annotation will be introduced in Java 16 as described in #10620. This change combines the check on value type instances and value based class objects.

@gita-omr
Copy link
Contributor

gita-omr commented Jan 5, 2021

@IBMJimmyk could you please review, especially on the subject of the temporary register being reused?

@IBMJimmyk
Copy link
Contributor

The only comment I had was addressed so this looks good to me.

@gita-omr
Copy link
Contributor

Jenkins test sanity aix,plinux jdk8,jdk11

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jan 18, 2021

@gita-omr All tests passed

@gita-omr gita-omr merged commit b981493 into eclipse-openj9:master Jan 18, 2021
@a7ehuo a7ehuo mentioned this pull request Jan 21, 2021
Merged
@a7ehuo a7ehuo deleted the jep390-valuedbased-power branch February 7, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila left review comments

@gita-omr gita-omr gita-omr left review comments

@IBMJimmyk IBMJimmyk IBMJimmyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7ehuo @gita-omr @IBMJimmyk @tajila