Update the version and copyright date for libFFI #14835
Conversation
| <h4>libFFI pre 3.4</h4> | ||
| libffi - Copyright (c) 1996-2021 Anthony Green, Red Hat, Inc and others. | ||
| <h4>libFFI 3.4.2</h4> | ||
| libffi - Copyright (c) 1996-2022 Anthony Green, Red Hat, Inc and others. |
There was a problem hiding this comment.
I'm not sure 2022 is correct, 3.4.2 is released in 2021. Are we taking more recent versions than 3.4.2?
There was a problem hiding this comment.
It might be ambiguous for version but we always take the latest changes from https://github.com/libffi/libffi instead of https://github.com/libffi/libffi/releases/tag/v3.4.2 (2021) which doesn't include the latest changes in RISC-V at #14699 which was merged earlier this year.
commit aa3fce08ba620c50db17215a9f14dd0f1facf741
Author: Andreas Schwab [schwab@linux-m68k.org](mailto:schwab@linux-m68k.org)
Date: Sun Feb 13 21:04:33 2022 +0100 <-------
There was a problem hiding this comment.
Then I think we should use pre 3.5 as the version.
There was a problem hiding this comment.
Updated to pre 3.5 as suggested.
Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
update_libffi_version_copyright_date
branch
from
c04993f
to
f4aea17
Compare
|
Can you pls backport "pre 3.4 & 2021" to the 0.31 and 0.32 branches. i.e. just the x86 changes are in those releases. |
|
PR with |
|
PR with |
This should have been done with previous changes eclipse-openj9#16305 eclipse-openj9#14835 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This should have been done with previous changes eclipse-openj9#16305 eclipse-openj9#14835 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Signed-off-by: Cheng Jin jincheng@ca.ibm.com