Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the version and copyright date for libFFI #14835

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Update the version and copyright date for libFFI #14835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions longabout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,8 @@ <h4>MurmurHash3</h4>
<p>
Note - The x86 and x64 versions do _not_ produce the same results, as the algorithms are optimized for their respective platforms. You can still compile and run any of them on any platform, but your performance with the non-native version will be less than optimal
<p>
<h4>libFFI pre 3.4</h4>
libffi - Copyright (c) 1996-2021 Anthony Green, Red Hat, Inc and others.
<h4>libFFI pre 3.5</h4>
libffi - Copyright (c) 1996-2022 Anthony Green, Red Hat, Inc and others.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure 2022 is correct, 3.4.2 is released in 2021. Are we taking more recent versions than 3.4.2?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be ambiguous for version but we always take the latest changes from https://github.com/libffi/libffi instead of https://github.com/libffi/libffi/releases/tag/v3.4.2 (2021) which doesn't include the latest changes in RISC-V at #14699 which was merged earlier this year.

commit aa3fce08ba620c50db17215a9f14dd0f1facf741
Author: Andreas Schwab [schwab@linux-m68k.org](mailto:schwab@linux-m68k.org)
Date: Sun Feb 13 21:04:33 2022 +0100 <-------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think we should use pre 3.5 as the version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to pre 3.5 as suggested.

See source files for details.
<p>
Permission is hereby granted, free of charge, to any person obtaining
Expand Down
2 changes: 1 addition & 1 deletion runtime/libffi/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
libffi - Copyright (c) 1996-2014 Anthony Green, Red Hat, Inc and others.
libffi - Copyright (c) 1996-2022 Anthony Green, Red Hat, Inc and others.
See source files for details.

Permission is hereby granted, free of charge, to any person obtaining
Expand Down
6 changes: 3 additions & 3 deletions runtime/libffi/about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<body lang="EN-US">
<h2>About This Content</h2>

<p><em>September 8, 2017</em></p>
<p><em>Mar 14, 2022</em></p>
<h3>License</h3>

<p>This program and the accompanying materials are made available under the terms of the
Expand Down Expand Up @@ -40,13 +40,13 @@ <h3>Third Party Content</h3>
Content directly from the Eclipse Foundation, the following is provided for informational purposes only, and you
should look to the Redistributor's license for terms and conditions of use.</p>

<h3>libffi 3.2.1</h3>
<h3>libFFI pre 3.5</h3>

<p>A Portable Foreign Function Interface Library, obtained from http://sourceware.org/libffi/<p>

<p>The software is modified from the original version.</p>

<p>libffi - Copyright (c) 1996-2014 Anthony Green, Red Hat, Inc and others.</p>
<p>libffi - Copyright (c) 1996-2022 Anthony Green, Red Hat, Inc and others.</p>

<p>
Permission is hereby granted, free of charge, to any person obtaining
Expand Down