Use JVM_VirtualThread* functions correctly with Virtual Threads #15755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
loom_jvmti_3
branch
2 times, most recently
from
0971d78
to
5c49a83
Compare
babsingh
commented
Aug 19, 2022
babsingh
changed the title
|
|
I think we want to avoid
I'll have a look at that. |
|
I expect the problem is that |
|
We will also want a repeat of ibmruntimes/openj9-openjdk-jdk19#23 for jdknext. |
babsingh
force-pushed
the
loom_jvmti_3
branch
from
32df9a3
to
0f564b6
Compare
babsingh
force-pushed
the
loom_jvmti_3
branch
from
0f564b6
to
701d5cc
Compare
|
babsingh
force-pushed
the
loom_jvmti_3
branch
2 times, most recently
from
1665394
to
f792fb2
Compare
|
jenkins test sanity win,xlinux jdk11,jdk19 |
|
@hangshao0 Only code has been moved from thread.cpp to javanextvmi.cpp. All other changes are needed to support the code move. Core functionality should not be impacted by these changes. |
hangshao0
reviewed
Sep 8, 2022
|
Old builds are still good:
|
babsingh
force-pushed
the
loom_jvmti_3
branch
from
f792fb2
to
0f8bb78
Compare
See comments at the end of eclipse-openj9#15704 for more details. Converted javanextvmi.c to a CPP file for including VMHelpers.hpp. Depends on ibmruntimes/openj9-openjdk-jdk19#23. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
loom_jvmti_3
branch
from
0f8bb78
to
d15c681
Compare
hangshao0
approved these changes
Sep 8, 2022
|
@tajila please review/merge. |
tajila
approved these changes
Sep 8, 2022
|
jenkins test sanity win,amac jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue from #15704 (comment).
Converted javanextvmi.c to a CPP file for including VMHelpers.hpp.
Depends on ibmruntimes/openj9-openjdk-jdk19#23.
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com