Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VirtualThread JVMTI natives by default #23

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

babsingh
Copy link
Member

@babsingh babsingh commented Aug 19, 2022

The VirtualThread natives are needed to keep a list of every live virtual
thread for JVMTI. Since JVMTI agents can be attached at any time, enable
these natives by default.

Issue: eclipse-openj9/openj9#15183
Related: eclipse-openj9/openj9#15755
Reference: eclipse-openj9/openj9#15704 (comment)

Co-authored-by: Eric Yang eric.yang@ibm.com
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

The VirtualThread natives are needed to keep a list of every live virtual
thread for JVMTI. Since JVMTI agents can be attached at any time, enable
these natives by default.

Issue: eclipse-openj9/openj9#15183

Co-authored-by: Eric Yang <eric.yang@ibm.com>
Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh changed the title Enable VirtualThread natives by default Enable VirtualThread JVMTI natives by default Aug 19, 2022
@babsingh
Copy link
Member Author

fyi @keithc-ca

@keithc-ca
Copy link
Member

jenkins test sanity amac jdk19

@keithc-ca keithc-ca self-requested a review August 22, 2022 15:29
@keithc-ca keithc-ca merged commit f520756 into ibmruntimes:openj9 Aug 22, 2022
@babsingh
Copy link
Member Author

babsingh commented Sep 6, 2022

Ported to jdknext: ibmruntimes/openj9-openjdk-jdk#485.

babsingh added a commit to babsingh/openj9 that referenced this pull request Sep 8, 2022
See comments at the end of eclipse-openj9#15704 for more details.

Converted javanextvmi.c to a CPP file for including VMHelpers.hpp.

Depends on ibmruntimes/openj9-openjdk-jdk19#23.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants