Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "substract" typo #16431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix "substract" typo #16431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/compiler/ilgen/Walker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1663,7 +1663,7 @@ TR_J9ByteCodeIlGenerator::stashArgumentsForOSR(TR_J9ByteCode byteCode)
// regardless of the number of arguments needed by the generated call.
//
// The generated call requires one (in resolved case) or two (in unresolved case)
// implicit arguments, so we need to substract them to get the actual number of
// implicit arguments, so we need to subtract them to get the actual number of
// arguments needed.
// The reason why we don't need to stash the implicit arguments is because when we
// transition to the VM, VM will push the implicit argument onto the stack, this is
Expand Down
10 changes: 5 additions & 5 deletions runtime/compiler/z/codegen/J9TreeEvaluator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2551,7 +2551,7 @@ J9::Z::TreeEvaluator::inlineUTF16BEEncodeSIMD(TR::Node *node, TR::CodeGenerator
processUnder8Chars->setStartInternalControlFlow();

// Calculate the number of residue bytes available
generateRRInstruction(cg, TR::InstOpCode::getSubstractRegOpCode(), node, inputLen, translated);
generateRRInstruction(cg, TR::InstOpCode::getSubtractRegOpCode(), node, inputLen, translated);

// Branch to the end if there is no residue
generateS390BranchInstruction(cg, TR::InstOpCode::BRC, TR::InstOpCode::COND_CC0, node, processUnder8CharsEnd);
Expand Down Expand Up @@ -2799,7 +2799,7 @@ J9::Z::TreeEvaluator::inlineStringHashCode(TR::Node* node, TR::CodeGenerator* cg
generateRSInstruction(cg, TR::InstOpCode::SLLK, node, registerTemp, registerHash, 5);

// registerTemp -= registerHash
generateRRInstruction(cg, TR::InstOpCode::getSubstractRegOpCode(), node, registerTemp, registerHash);
generateRRInstruction(cg, TR::InstOpCode::getSubtractRegOpCode(), node, registerTemp, registerHash);

// registerHash = char at registerIndex
if(isCompressed)
Expand Down Expand Up @@ -3549,8 +3549,8 @@ VMnonNullSrcWrtBarCardCheckEvaluator(
bool isConstantHeapSize = !comp->getOptions()->isVariableHeapSizeForBarrierRange0();
int32_t shiftAmount = TR::Compiler->om.compressedReferenceShift();
TR::InstOpCode::Mnemonic opLoadReg = TR::InstOpCode::getLoadRegOpCode();
TR::InstOpCode::Mnemonic opSubtractReg = TR::InstOpCode::getSubstractRegOpCode();
TR::InstOpCode::Mnemonic opSubtract = TR::InstOpCode::getSubstractOpCode();
TR::InstOpCode::Mnemonic opSubtractReg = TR::InstOpCode::getSubtractRegOpCode();
TR::InstOpCode::Mnemonic opSubtract = TR::InstOpCode::getSubtractOpCode();
TR::InstOpCode::Mnemonic opCmpLog = TR::InstOpCode::getCmpLogicalOpCode();
bool disableSrcObjCheck = true; //comp->getOption(TR_DisableWrtBarSrcObjCheck);
bool constantHeapCase = ((!comp->compileRelocatableCode()) && isConstantHeapBase && isConstantHeapSize && shiftAmount == 0 && (!is64Bit || TR::Compiler->om.generateCompressedObjectHeaders()));
Expand Down Expand Up @@ -3768,7 +3768,7 @@ VMCardCheckEvaluator(
// Defect 91242 - If we can clobber the destination reg, then use owningObjectReg instead of cardOffReg.
if (!clobberDstReg)
generateRRInstruction(cg, TR::InstOpCode::getLoadRegOpCode(), node, cardOffReg, owningObjectReg);
generateRXInstruction(cg, TR::InstOpCode::getSubstractOpCode(), node, cardOffReg,
generateRXInstruction(cg, TR::InstOpCode::getSubtractOpCode(), node, cardOffReg,
generateS390MemoryReference(mdReg, offsetof(J9VMThread, heapBaseForBarrierRange0), cg));

// Unless we know it's definitely a heap object, we need to check if offset
Expand Down